Skip to content

Fix Bugzilla Issue 24560 - dmd crash on imported function with default parameter containing new #16519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewilsonator merged 1 commit into from
May 27, 2024
Merged

Fix Bugzilla Issue 24560 - dmd crash on imported function with default parameter containing new #16519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions compiler/src/dmd/expressionsem.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15286,6 +15286,9 @@ Expression resolveLoc(Expression exp, const ref Loc loc, Scope* sc)

Expression visitStructLiteral(StructLiteralExp exp)
{
if (!exp.elements)
return exp;

foreach (ref element; *exp.elements)
{
if (element)
Expand All @@ -15304,6 +15307,9 @@ Expression resolveLoc(Expression exp, const ref Loc loc, Scope* sc)
if (exp.lowering)
exp.lowering = exp.lowering.resolveLoc(loc, sc);

if (!exp.arguments)
return exp;

foreach (ref element; *exp.arguments)
{
if (element)
Expand All @@ -15315,6 +15321,9 @@ Expression resolveLoc(Expression exp, const ref Loc loc, Scope* sc)

Expression visitCall(CallExp exp)
{
if (!exp.arguments)
return exp;

foreach (ref element; *exp.arguments)
{
if (element)
Expand All @@ -15328,6 +15337,9 @@ Expression resolveLoc(Expression exp, const ref Loc loc, Scope* sc)
{
exp.e1 = exp.e1.resolveLoc(loc, sc);

if (!exp.arguments)
return exp;

foreach (ref element; *exp.arguments)
{
if (element)
Expand Down Expand Up @@ -15361,6 +15373,9 @@ Expression resolveLoc(Expression exp, const ref Loc loc, Scope* sc)
if (exp.basis)
exp.basis = exp.basis.resolveLoc(loc, sc);

if (!exp.elements)
return exp;

foreach (ref element; *exp.elements)
{
if (element)
Expand Down
12 changes: 12 additions & 0 deletions compiler/test/compilable/test24560.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// https://issues.dlang.org/show_bug.cgi?id=24560

class C { }
struct S
{
static void fun(C heur = new C) { }
}

void main()
{
S.fun();
}