Repository navigation
Conversation
djkees
force-pushed
the
refactor/ifx-ifort-windows-env-capture
branch
from
September 14, 2026 18:23
f8c8bda to
e3d59f2
Compare
ifx and ifort each hand-rolled the same ~60-line batch-file generation (vswhere -> vcvars64.bat -> setvars.bat -> env dump), env-line parsing, and PATH filtering. PR fortran-lang#260 had to patch both copies identically to fix one PATH bug. Extracts it into captureIntelWindowsEnvironment() in a new intel_windows_env module; no behavior change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The rebase's dist/ conflict was resolved with a placeholder; this regenerates it fresh from source so it actually reflects the rebased tree. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
djkees
force-pushed
the
refactor/ifx-ifort-windows-env-capture
branch
from
September 14, 2026 18:50
e3d59f2 to
d728da0
Compare
Owner
Author
|
Moving this upstream: fortran-lang#268 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ifxandiforton Windows each hand-rolled the same ~60-line block: generate a batch file that runsvcvars64.batthen Intel'ssetvars.batand dumps the environment, parse the output, filter Git'slink.exeout ofPATH, and export the rest. PR fortran-lang#260 (the PATH-dedup fix) had to patch both copies identically — a sign this needed to be one function, not two.captureIntelWindowsEnvironment(setvarsBat, batchFileName)in a newsrc/intel_windows_env.ts.ifx/win32.tsandifort/win32.tsnow just call it with their ownsetvars.batpath and batch filename; dropped their now-unusedos/setup_msvcimports.709/709 unit tests pass; lint clean;
npm run build+ bundle smoke test both succeed (dist committed alongside source per the repo's convention).