Skip to content

Add missing newline in manage.py for black 26 compatibility#2217

Merged
carltongibson merged 1 commit intodjango:mainfrom
deronnax:fix-black-26-format-error
Mar 28, 2026
Merged

Add missing newline in manage.py for black 26 compatibility#2217
carltongibson merged 1 commit intodjango:mainfrom
deronnax:fix-black-26-format-error

Conversation

@deronnax
Copy link
Copy Markdown
Contributor

@deronnax deronnax commented Mar 28, 2026

I noticed the CI was red, and it was red because Black is unpined in tox settings, and since there has been a new year - 2026 -, Black updated its yearly syntax.
I just made this quick change, but:

  1. Linters version should be pinned
  2. I don't think code in test/sample_projects should turn CI red.

3 - bonus: The whole linting stuff, which goes through tox, it's very old-fashioned. I don't think the linting should go through tox anymore. If I get a core maintainer greenlight, I could just replicate here what django does in its main repo.

Copy link
Copy Markdown
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks.

@carltongibson carltongibson merged commit f078b09 into django:main Mar 28, 2026
7 checks passed
@carltongibson
Copy link
Copy Markdown
Member

@deronnax I'm happy with the tox config as it is thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants