Issue 34:- Handle events without coordinates to avoid placing them at…#121
Open
kehach07 wants to merge 1 commit intodjango:mainfrom
Open
Issue 34:- Handle events without coordinates to avoid placing them at…#121kehach07 wants to merge 1 commit intodjango:mainfrom
kehach07 wants to merge 1 commit intodjango:mainfrom
Conversation
… the map center. django#34 Events with missing or null coordinates were appearing at (0,0) on the map, creating incorrect markers in the ocean. Solution:- Filtered out events that have no valid latitude/longitude before rendering. Added a backup check inside pointToLayer to skip any invalid feature. ✔ Result Only events with real coordinates are displayed on the map, and invalid events are ignored, preventing wrong markers and wrong cluster behaviour.
Contributor
|
Hey - thanks for showing interest. Are you using AI for this or just very verbose? :) I think this solution would have been nicer to implement in Hugo. I would think this repo is fairly calm right now, and events without coordinates don't really seem to be an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 34:- Handle events without coordinates to avoid placing them at the map center. #34
Events with missing or null coordinates were appearing at (0,0) on the map, creating incorrect markers in the ocean.
Solution:-
Filtered out events that have no valid latitude/longitude before rendering.
Added a backup check inside pointToLayer to skip any invalid feature.
✔ Result
Only events with real coordinates are displayed on the map, and invalid events are ignored, preventing wrong markers and wrong cluster behaviour.