DEV: Eliminate discourse-smtp-fast-rejection#33
Merged
Conversation
This has been pointing to an endpoint in discourse core that has been broken for at least 9 years (smtp_should_reject), we will remove this endpoint from core in a future release. The protections in this fast rejection endpoint are done anyway when receiving mail in Discourse core.
Supermathie
approved these changes
Nov 21, 2025
martin-brennan
added a commit
to discourse/discourse
that referenced
this pull request
Nov 23, 2025
This has not worked in 9 years and will no longer be used by mail-receiver as at discourse/mail-receiver#33
martin-brennan
added a commit
to discourse/discourse
that referenced
this pull request
Nov 24, 2025
This has not worked in 9 years and will no longer be used by mail-receiver as at discourse/mail-receiver#33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been pointing to an endpoint in discourse
core that has been broken for at least 9 years
(smtp_should_reject), we will remove this endpoint
from core in a future release.
The protections in this fast rejection endpoint are
done anyway when receiving mail in Discourse core.