Skip to content

ValueError in util/urlsplit #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amit-siddhu wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −1
Open

ValueError in util/urlsplit #649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/disco/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ def host(self):
def port(self):
return self[1]

@property
def host_port(self):
return self[0], self[1]

def __nonzero__(host_port):
return bool(host_port[0])

Expand Down Expand Up @@ -169,7 +173,7 @@ def urlsplit(url, localhost=None, disco_port=None, **kwargs):
path, locstr = locstr, ''
else:
disco_port = disco_port or str(DiscoSettings()['DISCO_PORT'])
host, port = netloc.parse(locstr)
host, port = netloc.parse(locstr).host_port
if scheme == 'disco' or port == disco_port:
if localhost == True or locstr == localhost:
scheme = 'file'
Expand Down