[Review slice — do not merge] sampler-revamp source (dingo + compatibility)#398
Closed
stephengreen wants to merge 3 commits into
Closed
[Review slice — do not merge] sampler-revamp source (dingo + compatibility)#398stephengreen wants to merge 3 commits into
stephengreen wants to merge 3 commits into
Conversation
Member
Author
|
Review served its purpose: the ultra review ran on this slice via local-branch mode and its findings were applied to #389 (aux-SNR statistic fix + regression test, legacy import port, help-text typo). Closing; branch to be deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A scoping slice of #389 for ultrareview, which refuses the full PR (52 files / ~10k lines, and again at 9,988). This branch contains the source-code portion of #389 —
dingo/andcompatibility/— plus the accompanying test suite undertests/; only documentation is omitted.Note for the reviewer: this is a slice of #389, not a standalone change. The
tests/directory here contains the coverage for the source changes (chain machinery, sampler context, RA frames, heterodyne, BNS chain builder, composed samplers, importance-sampling prior updates, and a CUDA-gated device regression test). If a later push stripstests/from this PR, that removal is a size-cap workaround, not a coverage statement — the tests remain in #389; in that case please do not report missing-test findings for this slice.Not for merging: findings apply to #389, and this PR will be closed after the review runs.
🤖 Generated with Claude Code