Refactor pipe/#392
Draft
AlexandreGoettel wants to merge 2 commits into
Draft
Conversation
…fic code and inherited from bilby_pipe, and only define DINGO-specific arguments, removing ~1600 duplicate lines. ii) Remove deprecated logic and make bilby_pipe work for us whenever possible. iii) get settings from dingo model metadata when possible. iv) removed deprecated comment blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major refactor of parser and data generation:
(this removes the need for explicit pre/post bilby1.8 logic)
This is a draft so I can build more on top and see if the overall logic fits with what is wanted. I have a few tests, which however require a network so it's not immediately obvious how to test without adding O(MB) of data to the repo.