Skip to content

Improved logging (issue #152)#388

Open
cmfabbri wants to merge 7 commits into
hackathon-1from
logging
Open

Improved logging (issue #152)#388
cmfabbri wants to merge 7 commits into
hackathon-1from
logging

Conversation

@cmfabbri

@cmfabbri cmfabbri commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Replaces print() statements with logging calls, and integrates the dingo and bilby loggers so that both write to the same log file.

Changes:

  • dingo/core/utils/logging_utils.py - updated; sets up a "dingo" logger that shares bilby's file handler when bilby is available, falling back to a standalone file handler otherwise
  • replaced print() calls with logger.info() or logger.warning()
  • files in dingo/pipe/ now use logging.getLogger("dingo.pipe") instead of bilby_pipe's logger
  • print() kept in ls_cli.py, asimov.py (dryrun blocks) and main debug blocks

cmfabbri and others added 2 commits July 1, 2026 09:16
…ssue #152)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@stephengreen stephengreen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make sure that the creation of the logger is consistent with what @hcampe is doing with hydra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants