Dont transfer entire models for data generation#335
Open
AlexandreGoettel wants to merge 4 commits into
Open
Conversation
Collaborator
Author
|
I tested this locally and as a condor job on CIT, but I'm not sure how to report results. |
Collaborator
Author
|
ping @stephengreen |
nihargupte-ph
requested changes
Jul 1, 2026
nihargupte-ph
left a comment
nihargupte-ph
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for putting in the PR! 12 eyes looked at this PR.
Just one comment on the PR.
| if (value := getattr(self.inputs, attr)) is not None: | ||
| input_files_to_transfer.append(os.path.abspath(str(value))) | ||
|
|
||
| # modifying the paths for OSDF networks |
Collaborator
There was a problem hiding this comment.
Why are we removing this?
Collaborator
Author
There was a problem hiding this comment.
The generation node only needed the network files to be transferred so it could access their metadata. Since it can now get the metadata from the ini file, this removes the networks from the list of files to be transferred
|
CI is failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This formats the metadata saved inside of the model as a string and saves it in the .ini file. This way, the model metadata can be accessed basically automatically.
Addresses #327