Skip to content

Imr phenom xhm support #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sclyne623 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Imr phenom xhm support #263

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8039edc
Update waveform_generator.py to support IMRPhenomXHM
sclyne623 Oct 15, 2024
56dfae9
Update waveform_generator.py comment
sclyne623 Oct 15, 2024
9612604
Update waveform_generator.py
sclyne623 Oct 22, 2024
d23efb9
Update waveform_generator.py
sclyne623 Oct 22, 2024
546ff68
Modified wfg_utils so polarizations generate
sclyne623 Nov 1, 2024
60826ef
Updated if statement in `Generate_TD_Modes_L0` to
sclyne623 Jan 20, 2025
9efe92c
Merge branch 'dingo-gw:main' into IMRPhenomXHM_support
sclyne623 Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions dingo/gw/waveform_generator/waveform_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,9 +658,10 @@ def generate_FD_modes_LO(self, parameters):
values.
iota: float
"""
# TD approximants that are implemented in J frame. Currently tested for:
# 101: IMRPhenomXPHM
if self.approximant in [101]:
# FD Waveform approximants that are implemented in either the L0 or J frame. Currently tested for:
# 101: IMRPhenomXPHM, 97: IMRPhenomXHM
tested_approximants = ["IMRPhenomXPHM","IMRPhenomXHM"]
if LS.GetStringFromApproximant(self.approximant) in tested_approximants:
parameters_lal_fd_modes = self._convert_parameters(
{**parameters, "f_ref": self.f_ref},
lal_target_function="SimInspiralChooseFDModes",
Expand All @@ -674,13 +675,14 @@ def generate_FD_modes_LO(self, parameters):
# are returned in the J frame (where the observer is at inclination=theta_JN,
# azimuth=0). In this frame, the dependence on the reference phase enters
# via the modes themselves. We need to convert to the L0 frame so that the
# dependence on phase enters via the spherical harmonics.
hlm_fd = frame_utils.convert_J_to_L0_frame(
hlm_fd,
parameters,
self,
spin_conversion_phase=self.spin_conversion_phase,
)
# dependence on phase enters via the spherical harmonics.
if LS.GetStringFromApproximant(self.approximant) == "IMRPhenomXPHM":
hlm_fd = frame_utils.convert_J_to_L0_frame(
hlm_fd,
parameters,
self,
spin_conversion_phase=self.spin_conversion_phase,
)
return hlm_fd, iota
else:
raise NotImplementedError(
Expand Down