Skip to content

respect the eslint.disable config setting - #524

Open
woss wants to merge 1 commit into
dilanx:mainfrom
woss:fix-eslint-disable
Open

respect the eslint.disable config setting#524
woss wants to merge 1 commit into
dilanx:mainfrom
woss:fix-eslint-disable

Conversation

@woss

@woss woss commented Sep 11, 2023

Copy link
Copy Markdown

this fixes #281 and probably a few other things.

@woss
woss requested a review from dilanx as a code owner September 11, 2023 09:46
@uguremirmustafa

Copy link
Copy Markdown

Any update here?

@dilanx

dilanx commented Dec 29, 2023

Copy link
Copy Markdown
Owner

I don't believe this would fix anything. Trying to disable the eslint plugin when it isn't found would also throw a craco error.

Does removing the eslint section from your craco config resolve the issue?

@philsherry

Copy link
Copy Markdown

@dilanx To answer the above question:

“Does removing the eslint section from your craco config resolve the issue?”

It didn’t for me.

I came looking and searched for all mentions of ESLintWebpackPlugin, only to find a closed Issue and this open PR. I realise this PR is fairly stale now, but I thought I'd at least offer an answer to the question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

craco: *** Cannot find ESLint plugin (ESLintWebpackPlugin). ***

4 participants