fix(i18n): make english source-first across the app#1403
Draft
fix(i18n): make english source-first across the app#1403
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
jcllobet
changed the title
jcllobet
changed the title
Collaborator
Author
|
do not merge, @johnnyshields has a better take on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
td(key, english, localeOrParams?, params?)helper so visible English copy lives at the callsite while locale keys stay stable--source-first,--extract-source-first, andpnpm i18n:sync-ensoen.tsis verified against and synced from source-first defaultsapps/app/src/app/app.tsxfor unknown future busy-status keys; all static callsites now carry inline English defaultsTesting
pnpm installpnpm test:i18n:findpnpm test:i18n:source-firstnode scripts/i18n-audit.mjs --source-firstpnpm i18n:sync-enpnpm i18n:find -- "OpenWork server URL"pnpm i18n:find -- "Add Remote Workspace"node scripts/i18n-audit.mjs --duplicatespnpm --filter @openwork/app typecheckpnpm build:uiResult
scripts/i18n-audit.mjs --source-firstnow reports1296source-first defaults in sync withen.tsNotes
common.*remains a namespace for shared UI copy, not an escape hatch from localization