backport: fix: resolve OUG{} indicator count to zero when org unit has no group members [2.41]#24271
Open
jason-p-pickering wants to merge 1 commit into
Open
backport: fix: resolve OUG{} indicator count to zero when org unit has no group members [2.41]#24271jason-p-pickering wants to merge 1 commit into
jason-p-pickering wants to merge 1 commit into
Conversation
… members (#24266) ItemOrgUnitGroupCount.evaluate read visitor.getParams().getOrgUnitCountMap() unguarded. In the analytics indicator path (DataHandler.getIndicatorValue), the per-org-unit target count map is null when the org unit target aggregation returns no row for an org unit — i.e. when that org unit's subtree contains no members of the referenced group. This produced a NullPointerException (HTTP 500) on analytics requests for any indicator using OUG{} over such an org unit, e.g. GET /api/analytics.json?dimension=dx:<oug-indicator>&dimension=ou:LEVEL-3&dimension=pe:2025 A missing entry means a count of zero, not an error. Treat both a null map and a missing group entry as zero, consistent with how analytics treats absent counts. This also removes the prior "Cannot find count" throw, which likewise bubbled up as a 500 since getIndicatorValueObject does not catch it. Pre-existing latent bug (the unguarded line dates to 2023); rare because it requires an OUG{} indicator and an org unit whose subtree has zero matching members. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
jason-p-pickering
changed the title
jason-p-pickering
changed the title
jason-p-pickering
changed the title
netroms
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of 24aa365