Skip to content

[#355][IMP] Improve case close confirmation reminders #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasonwinget wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[#355][IMP] Improve case close confirmation reminders #1051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 170 additions & 14 deletions ui/src/pages/manage.cases.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,143 @@ function refresh_case_table() {
return true;
}

/* Create detail modal function */
function case_detail(id) {
url = 'cases/details/' + id + case_param();
$('#info_case_modal_content').load(url, function (response, status, xhr) {
function _extract_request_payload(request_data) {
if (Array.isArray(request_data)) {
return request_data[0];
}
return request_data;
}

if (status !== "success") {
ajax_notify_error(xhr, url);
return false;
function _pluralize(count, singular, plural) {
if (count === 1) {
return singular;
}
return plural;
}

function _get_case_close_failed_checks(case_data, tasks_data, assets_data) {
let failed_checks = [];

let tasks = [];
if (tasks_data && tasks_data.data && tasks_data.data.tasks) {
tasks = tasks_data.data.tasks;
}
let open_tasks = tasks.filter((task) => {
let status_name = '';
if (task && task.status_name) {
status_name = task.status_name;
}
return status_name !== 'Done' && status_name !== 'Canceled';
}).length;
if (open_tasks > 0) {
failed_checks.push(`${open_tasks} ${_pluralize(open_tasks, 'task remains', 'tasks remain')} open`);
}

$('#modal_case_detail').modal({ show: true });
let assets = [];
if (assets_data && assets_data.data && assets_data.data.assets) {
assets = assets_data.data.assets;
}
let analysis_status_counts = {};
for (let i = 0; i < assets.length; i++) {
let analysis_status = 'Unknown';
if (assets[i] && assets[i].analysis_status && assets[i].analysis_status.name) {
analysis_status = assets[i].analysis_status.name;
}
if (analysis_status === 'Done' || analysis_status === 'Unspecified') {
continue;
}
if (!(analysis_status in analysis_status_counts)) {
analysis_status_counts[analysis_status] = 0;
}
analysis_status_counts[analysis_status] += 1;
}
let pending_analysis_assets = Object.values(analysis_status_counts).reduce((acc, cur) => acc + cur, 0);
if (pending_analysis_assets > 0) {
let status_details = Object.keys(analysis_status_counts)
.sort()
.map((status) => `${analysis_status_counts[status]} ${status}`)
.join(', ');
failed_checks.push(
`${pending_analysis_assets} ${_pluralize(pending_analysis_assets, 'asset remains', 'assets remain')} pending analysis (${status_details})`
);
}

});
let compromise_review_assets = assets.filter((asset) => Number(asset && asset.asset_compromise_status_id) === 0).length;
if (compromise_review_assets > 0) {
failed_checks.push(
`${compromise_review_assets} ${_pluralize(compromise_review_assets, 'asset remains', 'assets remain')} in compromise review status (TBD)`
);
}

if (!case_data || !case_data.data || !case_data.data.classification_id) {
failed_checks.push('Case classification is not set');
}

if (case_data && case_data.data && Number(case_data.data.status_id) === 0) {
failed_checks.push('Case outcome is still set to Unknown');
}

return failed_checks;
}

/* Close case function */
function close_case(id) {
function _get_case_close_confirmation_content(id, failed_checks) {
let wrapper = document.createElement('div');
wrapper.style.maxWidth = '440px';

let question = document.createElement('p');
question.style.textAlign = 'center';
question.style.margin = '0 0 8px 0';
question.style.fontSize = '28px';
question.style.lineHeight = '1.2';
question.innerHTML = '<strong>Are you sure?</strong>';
wrapper.appendChild(question);

let details = document.createElement('p');
details.style.textAlign = 'center';
details.style.margin = '0';
details.style.color = '#5f6368';
details.textContent = `Case ID ${id} will be closed and will not appear in contexts anymore`;
wrapper.appendChild(details);

if (failed_checks.length > 0) {
let reminder_block = document.createElement('div');
reminder_block.style.marginTop = '16px';
reminder_block.style.padding = '12px 14px';
reminder_block.style.backgroundColor = '#fff7f2';
reminder_block.style.border = '1px solid #f6dccb';
reminder_block.style.borderRadius = '8px';
reminder_block.style.textAlign = 'left';

let reminder = document.createElement('p');
reminder.style.margin = '0 0 8px 0';
reminder.style.fontWeight = '600';
reminder.style.color = '#7a4a2f';
reminder.textContent = 'The following items are oustanding:';
reminder_block.appendChild(reminder);

let failed_checks_list = document.createElement('ul');
failed_checks_list.style.margin = '0 0 0 20px';
failed_checks_list.style.padding = '0';
failed_checks_list.style.color = '#4a4a4a';
failed_checks_list.style.lineHeight = '1.4';
for (let i = 0; i < failed_checks.length; i++) {
let item = document.createElement('li');
item.style.marginBottom = '6px';
item.style.fontSize = '14px';
item.textContent = failed_checks[i];
failed_checks_list.appendChild(item);
}
reminder_block.appendChild(failed_checks_list);
wrapper.appendChild(reminder_block);
}

return wrapper;
}

function _confirm_close_case(id, failed_checks) {
swal({
title: "Are you sure?",
text: "Case ID " + id + " will be closed and will not appear in contexts anymore",
icon: "warning",
content: _get_case_close_confirmation_content(id, failed_checks),
buttons: true,
dangerMode: true,
confirmButtonColor: '#3085d6',
Expand All @@ -48,6 +164,46 @@ function close_case(id) {
});
}

/* Create detail modal function */
function case_detail(id) {
url = 'cases/details/' + id + case_param();
$('#info_case_modal_content').load(url, function (response, status, xhr) {

if (status !== "success") {
ajax_notify_error(xhr, url);
return false;
}

$('#modal_case_detail').modal({ show: true });

});
}

/* Close case function */
function close_case(id) {
$.when(
get_raw_request_api(`/manage/cases/${id}`),
get_request_api('/case/tasks/list', false, null, id),
get_request_api('/case/assets/filter', false, null, id)
)
.done((case_data_request, tasks_data_request, assets_data_request) => {
let case_data = _extract_request_payload(case_data_request);
let tasks_data = _extract_request_payload(tasks_data_request);
let assets_data = _extract_request_payload(assets_data_request);

if (api_request_failed(case_data) || api_request_failed(tasks_data) || api_request_failed(assets_data)) {
_confirm_close_case(id, []);
return;
}

let failed_checks = _get_case_close_failed_checks(case_data, tasks_data, assets_data);
_confirm_close_case(id, failed_checks);
})
.fail(() => {
_confirm_close_case(id, []);
});
}

/* Reopen case function */
function reopen_case(id) {
post_request_api(`/manage/cases/reopen/${id}`)
Expand Down Expand Up @@ -381,4 +537,4 @@ function remove_cases_access_user(user_id, cases, on_finish) {
}
});

}
}