Skip to content

[IMP] Add markdown rendering for alert notes #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandervandegeijn wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

[IMP] Add markdown rendering for alert notes #1045

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0bae791
[IMP] Add markdown rendering for alert notes
Mar 5, 2026
9380b91
[FIX] Preserve raw markdown when editing alert notes
Mar 5, 2026
80f3b8d
[FIX] Sanitize markdown after conversion, not before
Mar 5, 2026
b792f90
[FIX] Fetch raw markdown from API when editing alert notes
Mar 5, 2026
bd6c0cf
[IMP] Increase alert note textarea to rows=10, consistent with other …
Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions source/app/static/assets/js/iris/alerts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
let sortOrder ;

function renderAlertNoteMarkdown(noteText) {
if (!noteText) return '';
let converter = get_showdown_convert();
let html = converter.makeHtml(do_md_filter_xss(noteText));
return do_md_filter_xss(html);
Comment thread
sandervandegeijn marked this conversation as resolved.
}

function objectToQueryString(obj) {
return Object.keys(obj)
.filter(key => obj[key] !== undefined && obj[key] !== null && obj[key] !== '')
Expand Down Expand Up @@ -853,7 +860,7 @@ function renderAlert(alert, expanded=false, modulesOptionsAlertReq,
alert.alert_source = alert.alert_description ? filterXSS(alert.alert_source) : 'No source provided';
alert.alert_source_link = filterXSS(alert.alert_source_link);
alert.alert_source_ref = filterXSS(alert.alert_source_ref);
alert.alert_note = filterXSS(alert.alert_note);
alert.alert_note = alert.alert_note || '';

let menuOptionsHtmlAlert = '';
const menuOptions = modulesOptionsAlertReq;
Expand Down Expand Up @@ -1004,7 +1011,7 @@ function renderAlert(alert, expanded=false, modulesOptionsAlertReq,

<div class="separator-solid"></div>
<h3 class="title mb-3"><strong>Alert note</strong></h3>
<pre id=alertNote-${alert.alert_id}>${alert.alert_note}</pre>
<div id="alertNote-${alert.alert_id}">${renderAlertNoteMarkdown(alert.alert_note)}</div>
Comment thread
coderabbitai[bot] marked this conversation as resolved.

<!-- Alert Context section -->
${
Expand Down