docs(references): expand protocol-canisters with Bitcoin cycle costs, SOL RPC, and Dogecoin canister#221
Closed
marc0olo wants to merge 2 commits intoinfra/learn-hub-migration-prepfrom
Closed
Conversation
## Summary - Adds `preview-deployment.yml`: triggered on PR open/sync/reopen for non-fork PRs. Requests a canister from the pool, builds and deploys the site to it with `icp deploy frontend -e ic --mode reinstall`, and posts the preview URL as a bot comment. - Adds `pr-cleanup.yml`: triggered on PR close. Returns the canister to the pool and deletes the bot comment. - Adds `.github/workflows/scripts/`: `pool.py`, `request-canister.py`, `release-canister.py`, `comments.cjs` — adapted from `dfinity/portal`. Changes from portal originals: env var renamed `ICP_IDENTITY_PREVIEW` → `POOL_CONTROLLER_IDENTITY`; `comments.js` renamed to `comments.cjs` to avoid ESM conflict with `"type": "module"` in `package.json`. - Updates `build.yml`: now only runs for fork PRs. Non-fork PRs get their build check through `preview-deployment.yml` (which fails the job if the build or deploy fails). - Bumps `icp-cli` from `0.2.0` to `0.2.6` in both `preview-deployment.yml` and `deploy-ic.yml`. ## Differences from portal | | portal | developer-docs | |---|---|---| | Secret name | `DFX_IDENTITY_PREVIEW` | `POOL_CONTROLLER_IDENTITY` | | Canister name | `portal` | `frontend` | | icp-cli install | curl installer `v0.1.0` | `npm i -g @icp-sdk/icp-cli@0.2.6` | | Node version | 20 | 22 | | comments helper | `comments.js` | `comments.cjs` (ESM fix) | ## Prerequisites (outside this PR) - `POOL_CONTROLLER_IDENTITY` and `POOL_CANISTER_ID` secrets must be set in repo settings (confirmed done). - The identity behind `POOL_CONTROLLER_IDENTITY` must be a controller of the pool canisters. ## Sync recommendation `hand-written`
… SOL RPC, and Dogecoin canister - Add get_blockchain_info to Bitcoin canister key endpoints - Add cycle costs table for all Bitcoin canister endpoints (from Bitcoin guide as authoritative source) - Add Dogecoin canister section with API endpoints (ID pending repo lookup) - Add withdrawal fee formula and UTXO consolidation info to ckBTC minter section (needs DeFi team verification) - Add SOL RPC canister section with canister ID, providers, and guide link - Add SOL RPC to quick reference table
Member
Author
|
Closing — changes folded into PR #213 which correctly targets infra/learn-hub-migration-prep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_blockchain_infoto Bitcoin canister key endpoints (new endpoint, added recently)Context
Follow-up to the chain fusion content audit from PR #213. The reference layer was missing: Bitcoin cycle costs (only existed in the guide), SOL RPC canister reference entry, and a full Dogecoin canister section. The ckBTC minter fee formula and UTXO consolidation parameters were in the concept page — moved here as the correct home for operational reference data.
Sync recommendation
hand-written— sourced fromguides/chain-fusion/bitcoin.mdx(cycle costs),guides/chain-fusion/solana.mdx(SOL RPC canister ID), andconcepts/chain-fusion/bitcoin.md(minter fee formula, UTXO consolidation — needs DeFi team verification)Note for reviewers
The minter fee formula (
146 × inputs + 4 × outputs + 26satoshi) and UTXO consolidation thresholds came from the Learn Hub (now retired). A DeFi team member should verify these against the live ckBTC minter code before this merges. An HTML comment marks the section.