Repository navigation
feat: Add serviceAccount.automountServiceAccountToken value - #168
Open
bruno-espino wants to merge 1 commit into
Open
bruno-espino wants to merge 1 commit into
bruno-espino wants to merge 1 commit into
Conversation
Signed-off-by: Bruno Espino <brunoespi7@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a
serviceAccount.automountServiceAccountTokenvalue rendered asspec.automountServiceAccountTokenon the Dex Deployment pod template.What this PR does / why we need it
A pod-mounted service account token is a cluster credential usable against the Kubernetes API server. Dex deployments that don't call the Kubernetes API (static configuration from a secret, non-Kubernetes storage) have no use for it, but the chart always leaves it automounting, including on the default service account when
serviceAccount.createis false. This PR makes the field configurable:The value defaults to
true, matching the Kubernetes default, so existing installs render identically unless they opt in.Special notes for your reviewer
Rendered and validated with
helm lint,helm templatewith the default and an overridden value, and allci/values files.Checklist
Chart.yamlChart.yamlmake docs