Repository navigation
feat: add allowed_hosts and trusted_networks to host resource - #340
Open
andopando19 wants to merge 1 commit into
Open
andopando19 wants to merge 1 commit into
andopando19 wants to merge 1 commit into
Conversation
Recent versions reject the host config without allowed hosts unless authentication is required for everyone, so the resource could no longer be applied. Both attributes are optional and default to the current value. Requires a radarr-go release that includes allowedHosts and trustedNetworks in HostConfigResource. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339
Current Radarr rejects saving the host config without Allowed Hosts unless authentication is required for everyone, so
radarr_hostcan't be applied any more. This addsallowed_hostsandtrusted_networksto theradarr_hostresource and data source.Behaviour
", "when sending. Radarr reformatstrustedNetworkson save (a,bcomes back asa, b), so a plain string attribute would give "inconsistent result after apply" errors.Tests
allowed_hosts, because the test config usesrequired = "disabledForLocalAddresses", which Radarr now rejects without allowed hosts. It also setstrusted_networksand checks both after create and update.Depends on
A radarr-go release that includes
allowedHostsandtrustedNetworksonHostConfigResource, generated with devopsarr/sdk-generator#585. This branch won't compile until then. I'll add thego.modbump once it's released.🤖 Generated with Claude Code