Fix broken link and content errors in JWT Pizza pages - #228
Open
MaxThePrisberry wants to merge 3 commits into
Open
MaxThePrisberry wants to merge 3 commits into
MaxThePrisberry wants to merge 3 commits into
Conversation
The link to the JWT Pizza Service instructions pointed at a folder - MasteryLS rendered it as a raw GitHub URL, which 404s. It now points at jwtPizzaService.md. Also fixes: - "cloned ... to your account" is now "forked". You fork to your account and clone to your machine. - The youracountname typo in the example URL.
The steps after the exercise said to create src/config.json, but the setup steps earlier on the same page create src/config.js with module.exports. Also fixes: - "JWT Pizza repo URL" is now "JWT Pizza Service repo URL", matching the example under it. - "cloned ... to your account" is now "forked". You fork to your account and clone to your machine. - The youracountname typo in the example URL. - "Once you have the backend service is running" is now "Once the backend service is running".
The TDD row said "Deploy frontend to AWS CloudFront" - a copy of the frontend deployment row under it. The TDD deliverable has you build update user, list users and delete user, so the row now describes that. Also fixes "Each of the follow deliverables" to "following".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a broken link and two content errors on the JWT Pizza pages, plus some wording. There's one commit per file.
src/config.json, but the setup steps earlier on the page createsrc/config.js.The rest is wording. Both repo exercises said to clone the repo to your account, and now say fork. There are also a few typo fixes.