Skip to content

Async lazy pagination crash - marked as static but it's never static #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devnatan merged 2 commits into from
Sep 13, 2023
Merged

Async lazy pagination crash - marked as static but it's never static #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6df202e
Async is not static
devnatan Sep 13, 2023
d9fab09
Remove debug
devnatan Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...framework-core/src/main/java/me/devnatan/inventoryframework/component/PaginationImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public PaginationImpl(
this.currSource = convertSourceProvider();
this.isComputed = isComputed;
this.isAsync = isAsync;
this.isStatic = sourceProvider instanceof Collection || isAsync;
this.isStatic = sourceProvider instanceof Collection;
this.isLazy =
!isStatic && !isComputed && (sourceProvider instanceof Function || sourceProvider instanceof Supplier);
}
Expand Down
4 changes: 2 additions & 2 deletions inventory-framework-platform/src/main/java/me/devnatan/inventoryframework/PlatformView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ protected final <T> State<T> initialState() {
* Creates a new immutable pagination with static data source.
*
* @param sourceProvider The data source for pagination.
* @param elementConsumer The function for creating pagination items, this function is called for
* @param elementConsumer The function for creating pagination items, this function is called for
* each paged element (item) on a page.
* @param <T> The pagination data type.
* @return A new immutable pagination state.
Expand Down Expand Up @@ -602,7 +602,7 @@ protected final <T> State<Pagination> computedPaginationState(
* such API may be changed or may be removed completely in any further release. </i></b>
*
* @param sourceProvider The data source for pagination.
* @param valueConsumer The function for creating pagination items, this function is called for
* @param valueConsumer The function for creating pagination items, this function is called for
* each paged element (item) on a page.
* @param <T> The pagination data type.
* @return A new unmodifiable pagination state.
Expand Down