Skip to content

Fix lazy pagination reloading - #458

Merged
devnatan merged 25 commits into
mainfrom
fix/dynamic-pagination-reloading
Sep 12, 2023
Merged

Fix lazy pagination reloading#458
devnatan merged 25 commits into
mainfrom
fix/dynamic-pagination-reloading

Conversation

@devnatan

@devnatan devnatan commented Sep 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Owner

Fixes #453

paginationState methods that accepts Function-like parameter as source provider is now computedPaginationState to match computedState. Computed state is used to create endless pagination so only Function is accepted as source provider (Supplier was removed).

asyncPaginationState is now computedAsyncPaginationState to match computedState as well.
lazyPaginationState introduced to match lazyState.

@devnatan devnatan added the bug Something isn't working label Sep 10, 2023
@devnatan devnatan added this to the Release v3.0.0-rc.3 milestone Sep 10, 2023
@devnatan devnatan self-assigned this Sep 10, 2023
@devnatan
devnatan force-pushed the fix/dynamic-pagination-reloading branch from 42d9156 to 1cf43e3 Compare September 10, 2023 19:18
@devnatan
devnatan force-pushed the fix/dynamic-pagination-reloading branch from 1cf43e3 to 6a34685 Compare September 10, 2023 19:57
@devnatan
Reuse dynamic pagination
6c595d8
@devnatan
Switch pageChanged state immediately after update
0612425
@devnatan
Fix isLazy check on constructor
419ab87
@devnatan
Remove NotNull annotations from constructor
2bdac31
@devnatan
Minor optimizations
ba9e3d9
@devnatan
Lock child interactions while page is being updated
a2ae4f6
@devnatan
Inherit ItemComponent visibility from root
7a3bf8d
@devnatan
Pagination own visibility state
f408417
@devnatan
Remove manual visibility switch from ItemComponent's clear()
38f9f36
@devnatan
Use ArrayList for components and optimize reuse
872f099 
Now list is recreated instead of cleared
@devnatan
Expose pagination page split function
dcb7305
@devnatan
Documentation to isStatic and isLazy
bd35b80
@devnatan
Rename PaginationElementConsumer to PaginationValueConsumer
38c96c8
@devnatan
Explicit computed pagination state
9073e38
@devnatan
Update visibility of pagination component
37393e8
@devnatan
Call update interceptor only if context is rendered
693c73d
@devnatan
Use non-deprecated versions of buildComputedState
8f7a7cd
@devnatan
Use parent context as subject to context clear
b107adc
@devnatan
Fix isLazy assignment
c14b0fc
@devnatan
Drop computedState with Supplier and add async ones
754a1f7
@devnatan
Optimize lazy source assignment by splitting it properly on initial i…
06c7056 
…nitialization
@devnatan
Re-assign page count only in reuse of non-lazy pagination
6a90bb0
@devnatan
Make changes binary incompatible
a9327fe
@devnatan
devnatan merged commit e257d04 into main Sep 12, 2023
@devnatan
devnatan deleted the fix/dynamic-pagination-reloading branch September 12, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@devnatan devnatan

Labels

bug Something isn't working

Projects

None yet

Milestone

Release v3.0.0-rc.3

Development

Successfully merging this pull request may close these issues.

Pagination bug

1 participant

@devnatan