Skip to content

Move onInit() to platform module #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devnatan merged 1 commit into from
Sep 10, 2023
Merged

Move onInit() to platform module #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions inventory-framework-api/src/main/java/me/devnatan/inventoryframework/RootView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,6 @@ public interface RootView extends VirtualView {
@ApiStatus.Internal
Set<IFContext> getInternalContexts();

/**
* Called when the view is about to be configured, the returned object will be the view's
* configuration.
* <p>
* As a reference, the data defined here was defined in the constructor in previous versions.
*
* @param config A mutable ViewConfigBuilder to configure this view.
*/
@ApiStatus.OverrideOnly
void onInit(ViewConfigBuilder config);

/**
* The configuration for this view.
*
Expand Down
3 changes: 0 additions & 3 deletions inventory-framework-core/src/main/java/me/devnatan/inventoryframework/DefaultRootView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ public final void setConfig(@NotNull ViewConfig config) {
return pipeline;
}

@Override
public void onInit(ViewConfigBuilder config) {}

@ApiStatus.Internal
public @NotNull ElementFactory getElementFactory() {
throw new UnsupportedOperationException("Element factory not provided");
Expand Down
5 changes: 1 addition & 4 deletions inventory-framework-platform/src/main/java/me/devnatan/inventoryframework/PlatformView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,12 +654,9 @@ final <V> State<Pagination> buildPaginationState(
/**
* Called when the view is about to be configured, the returned object will be the view's
* configuration.
* <p>
* As a reference, the data defined here was defined in the constructor in previous versions.
*
* @param config A mutable ViewConfigBuilder to configure this view.
* @param config A ViewConfigBuilder instance to configure this view.
*/
@Override
@ApiStatus.OverrideOnly
public void onInit(ViewConfigBuilder config) {}

Expand Down