Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3034 +/- ##
==========================================
- Coverage 83.93% 83.84% -0.10%
==========================================
Files 258 258
Lines 55676 55762 +86
Branches 4772 4785 +13
==========================================
+ Hits 46732 46752 +20
- Misses 8128 8191 +63
- Partials 816 819 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| if tkn is None: | ||
| tkn = 0 | ||
| else: | ||
| loc_size = distributor.shape[ |
There was a problem hiding this comment.
looks like distributor.shape wants to be a DimensionTuple..
| # and then add 1 to get the appropriate thickness | ||
| # Dimension is of type `left`/`right` - compute the offset and | ||
| # then add 1 to get the appropriate thickness. `glb_to_loc` | ||
| # saturates to the local size when the layer covers the whole |
There was a problem hiding this comment.
no idea what these two lines mean
There was a problem hiding this comment.
are you sure we're not breaking the contract here?
https://github.com/devitocodes/devito/blob/main/devito/types/dimension.py#L708-L710
if we break the contract, we should rather throw an exception
| assert np.all(glb[:, -3:] == 2.) | ||
|
|
||
| @pytest.mark.parallel(mode=[(3, 'basic'), (4, 'basic')]) | ||
| def test_initialize_function_pad_over_rank(self, mode): |
There was a problem hiding this comment.
I think this test belongs to test_builtins.py
|
|
||
| def _global_plane(function, axis, index): | ||
| """ | ||
| The plane of `function` at global position `index` along `axis`, assembled |
There was a problem hiding this comment.
I don't understand this docstring -- can u add an example?
| """ | ||
| Replicate the boundary planes of `function` outwards into its padding. | ||
|
|
||
| Used in place of the symbolic extension when a rank owns no interior to read |
There was a problem hiding this comment.
Maybe I don't understand exactly, but is this to cover the case in which one of the ranks at the border spans the whole left/right thickness , in practice, and so it doesn't have enough interior points to "apply padding" ? and when u say "padding", wdym exactly here?
There was a problem hiding this comment.
It's the opposite. This is whena rank is smaller than the thickness so the edge value needed to pad belongs to a different rank. The rank doesn't see the interior
|
|
||
|
|
||
| def _initialize_function(function, data, nbl, mapper=None, mode='constant'): | ||
| def _rank_without_interior(function, nbl): |
There was a problem hiding this comment.
Is distributor.loc_empty of use here or is this subtly different? Is any of the functionality attached to Distributor/SubDistributor useful here?
There was a problem hiding this comment.
This is not empty, it's smaller than the biundary layer so it doesn't have access to the edge hyperplane to pad
|
|
||
| def _global_plane(function, axis, index): | ||
| """ | ||
| The plane of `function` at global position `index` along `axis`, assembled |
This branch has not been deployed
3 participants
No description provided.