compiler: Improve DDA involving SubDimensions - #3029
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3029 +/- ##
==========================================
+ Coverage 83.84% 83.87% +0.02%
==========================================
Files 258 258
Lines 55281 55356 +75
Branches 4719 4730 +11
==========================================
+ Hits 46351 46428 +77
+ Misses 8113 8112 -1
+ Partials 817 816 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FabioLuporini
added
the
no-pro-trigger
mloubout
approved these changes
Sep 17, 2026
| # E.g., `f[xl]` over `(xl,)` and `f[xm]` over `(xm,)` need this | ||
| # special test, while accesses over the same `(xl,)` should use general | ||
| # distance analysis, so we can return immediately in such a case | ||
| if not (d0.is_Sub and |
Contributor
There was a problem hiding this comment.
Ultra nit-picking. not d0.is_Sub or not d1.is_Sub or .... is a better check as it will stop at the first True instead of evaluating the whole condition.
Contributor
Author
There was a problem hiding this comment.
- I'd be surprised if the bytecode isn't optimized already for this kind of things
- nah, as soon as
d0.is_Subis False, the inner condition gets evaluated immediately, so it stops immediately anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.