Adding bubblewrap and socat as these are dependencies for sandboxing.#1857
Open
dileepyavan wants to merge 3 commits intomainfrom
Open
Adding bubblewrap and socat as these are dependencies for sandboxing.#1857dileepyavan wants to merge 3 commits intomainfrom
dileepyavan wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds bubblewrap and socat to the Universal image to satisfy sandboxing dependencies needed by VS Code, and updates the Universal test project to assert the packages are present.
Changes:
- Install
bubblewrapandsocatinsrc/universal/.devcontainer/Dockerfile. - Extend the Universal test project OS package checks to include
bubblewrapandsocat.
Show a summary per file
| File | Description |
|---|---|
| src/universal/.devcontainer/Dockerfile | Installs bubblewrap and socat via apt to include sandboxing dependencies in the built image. |
| src/universal/test-project/test-utils.sh | Updates the common OS package validation list to ensure the new dependencies are installed. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/universal/.devcontainer/Dockerfile:64
src/universal/manifest.jsondocuments the base apt packages included in the Universal image, but it currently does not listbubblewraporsocat. After adding these packages to the build, please update the manifest’sdependencies.aptlist (and any related docs like the README/history if they enumerate contents) to keep the published documentation accurate.
curl \
gettext \
inotify-tools \
bubblewrap \
socat \
- Files reviewed: 2/2 changed files
- Comments generated: 1
Agent-Logs-Url: https://github.com/devcontainers/images/sessions/cb2f0ee6-1665-4bdc-8424-6e76fbfffa29 Co-authored-by: dileepyavan <52841896+dileepyavan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For sandboxing in vscode, bubblewrap and socat are dependency packages needed to be available.