Skip to content

Fix docker in docker not working in ubuntu 26.04#1634

Open
SrzStephen wants to merge 2 commits intodevcontainers:mainfrom
SrzStephen:fix/devcontainers
Open

Fix docker in docker not working in ubuntu 26.04#1634
SrzStephen wants to merge 2 commits intodevcontainers:mainfrom
SrzStephen:fix/devcontainers

Conversation

@SrzStephen
Copy link
Copy Markdown

@SrzStephen SrzStephen commented May 2, 2026

Closes #1633

#1235 references fedora specifically and I see a few merges that are already in that seem to be fedora specific

I have intentionally tried to only touch the existing ubuntu components that I am able to test

Testing

devcontainer features test --features docker-in-docker --filter docker_build --project-folder .

Before

🔄 Testing 'docker-ps'

Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?


❌ docker-ps check failed.

🔄 Testing 'docker-build'

ERROR: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?


❌ docker-build check failed.

After

Test Passed!
🧪 Executing duplicate test for feature 'docker-in-docker'...
⚠️ Skipping duplicate test for docker-in-docker because '/home/stephen/code/patch-features/test/docker-in-docker/duplicate.sh' does not exist.


  ================== TEST REPORT ==================
✅ Passed:      'docker-in-docker'
✅ Passed:      'docker_build_fallback_compose'
✅ Passed:      'docker_build'
✅ Passed:      'docker_build_with_compose_switch'
✅ Passed:      'docker_build_2'
✅ Passed:      'docker_build_older'
✅ Passed:      'docker_build_no_compose'
✅ Passed:      'docker_buildx'
✅ Passed:      'docker_build_fallback_buildx'

…nges

nat': Table does not exist (do you need to insmod?)\nPerhaps iptables or your kernel needs to be upgraded.\n (exit status 3)
@SrzStephen SrzStephen requested a review from a team as a code owner May 2, 2026 15:43
@SrzStephen SrzStephen changed the title Fix docker in docker not working in newer debian kernels Fix docker in docker not working in ubuntu 26.04 May 2, 2026
@SrzStephen
Copy link
Copy Markdown
Author

SrzStephen commented May 2, 2026

I'm trying to touch the least code possible since I don't fully understand why the debian specific check was added here

#1425 looks like it's trying to accomplish a similar thing but lacks the fallback that this has so the tests fail, arguably this PR should be made on top of that since #1425 has actually added tests for this case, but I'm not sure why it hasn't been merged in yet so I'm trying a smaller commit here.

fork-features on  fix-1235 [!]
❯ devcontainer features test --features docker-in-docker --filter docker_build --project-folder .

🔄 Testing 'docker-ps'

Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?


❌ docker-ps check failed.

Edit:
I've made some changes on top of #1425 https://github.com/SrzStephen/fork-features/tree/fix-1235 , I'll see how Oliver wants to deal with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker-in-docker feature not working on Ubuntu 26.04

1 participant