Fix docker in docker not working in ubuntu 26.04#1634
Open
SrzStephen wants to merge 2 commits intodevcontainers:mainfrom
Open
Fix docker in docker not working in ubuntu 26.04#1634SrzStephen wants to merge 2 commits intodevcontainers:mainfrom
SrzStephen wants to merge 2 commits intodevcontainers:mainfrom
Conversation
…nges nat': Table does not exist (do you need to insmod?)\nPerhaps iptables or your kernel needs to be upgraded.\n (exit status 3)
Author
|
I'm trying to touch the least code possible since I don't fully understand why the debian specific check was added here #1425 looks like it's trying to accomplish a similar thing but lacks the fallback that this has so the tests fail, arguably this PR should be made on top of that since #1425 has actually added tests for this case, but I'm not sure why it hasn't been merged in yet so I'm trying a smaller commit here. fork-features on fix-1235 [!] Edit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1633
#1235 references fedora specifically and I see a few merges that are already in that seem to be fedora specific
I have intentionally tried to only touch the existing ubuntu components that I am able to test
Testing
devcontainer features test --features docker-in-docker --filter docker_build --project-folder .Before
After