build(deps)!: bump cosmos sdk to v0.50.3 by dadamu · Pull Request #1246 · desmos-labs/desmos

dadamu · 2023-09-22T10:29:36Z

Description

Closes: #XXXX
This PR bumps cosmos-sdk to v0.50.0, ibc-go to v8 and wasmd to v0.50.0.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

dadamu · 2023-09-28T11:53:23Z

+// --------------------------------------------------------------------------------------------------------------------
+
+// MsgSaveProfile represents a message to save a profile.
+message MsgSaveProfile {


structures of MsgServices must be inside the same file as MsgServices, or cosmos.msg.v1.signer cannot be detected properly.

dadamu · 2023-09-28T15:10:59Z

 module github.com/desmos-labs/desmos/v6

-go 1.19
+go 1.21


Currently, cosmos-sdk, wasmd and ibc-go are set 1.21 as minimal version. Additionally, ibc-go applies features go 1.20 package.

dadamu · 2023-09-28T15:20:25Z

-				upgradeclient.LegacyProposalHandler,
-				upgradeclient.LegacyCancelProposalHandler,
-				ibcclientclient.UpdateClientProposalHandler,
-				ibcclientclient.UpgradeProposalHandler,


govv1beta1 proposal handler are deprecated

dadamu · 2023-09-28T15:25:42Z


 // BuildChainLinkJSON implements ChainLinkJSONBuilder
-func (b *AccountChainLinkJSONBuilder) BuildChainLinkJSON(_ codec.Codec, chain types.Chain) (utils.ChainLinkJSON, error) {
+func (b *AccountChainLinkJSONBuilder) BuildChainLinkJSON(ctx client.Context, chain types.Chain) (utils.ChainLinkJSON, error) {


inject client.Context for signing data since client.Context is required for signing bytes in this version

dadamu · 2023-09-28T15:32:47Z

+//
+// CONTRACT: Validator array must be provided in the order expected by Tendermint.
+// i.e. sorted first by power and then lexicographically by address.
+func NewTestChainWithValSet(tb testing.TB, coord *ibctesting.Coordinator, chainID string, valSet *cmttypes.ValidatorSet, signers map[string]cmttypes.PrivValidator) *ibctesting.TestChain {


FinalizeBlock is applied in cosmos-sdk v0.50, it breaks the ibctesting tool features, so I decided to wrap the existing tool from ibc-go, instead of maintaining it by ourselves.

dadamu · 2023-09-28T15:41:13Z

-var (
-	amino = codec.NewLegacyAmino()
-
-	// AminoCdc references the global x/relationships module codec. Note, the codec should
-	// ONLY be used in certain instances of tests and for JSON encoding as Amino is
-	// still used for that purpose.
-	//
-	// The actual codec used for serialization should be provided to x/relationships and
-	// defined at the application level.
-	AminoCdc = codec.NewAminoCodec(amino)
-
-	ModuleCdc = codec.NewProtoCodec(types.NewInterfaceRegistry())
-)
-
-func init() {
-	RegisterLegacyAminoCodec(amino)
-	cryptocodec.RegisterCrypto(amino)
-	sdk.RegisterLegacyAminoCodec(amino)
-
-	// Register all Amino interfaces and concrete types on the authz Amino codec so that this can later be
-	// used to properly serialize MsgGrant and MsgExec instances
-	RegisterLegacyAminoCodec(authzcodec.Amino)
-
-	// Register all Amino interfaces and concrete types on the gov Amino codec so that this can later be
-	// used to properly serialize MsgSubmitProposal instances
-	RegisterLegacyAminoCodec(govcodec.Amino)
-}


AminoCodec and init() function is deprecated
https://docs.cosmos.network/v0.50/build/migrations/upgrading#modules

Messages no longer need to implement the LegacyMsg interface and implementations of GetSignBytes can be deleted. Because of this change, global legacy Amino codec definitions and their registration in init() can safely be removed as well.

dadamu · 2023-09-28T15:42:17Z

-// GetSignBytes implements sdk.Msg.
-func (msg *MsgUnlinkApplication) GetSignBytes() []byte {
-	return sdk.MustSortJSON(AminoCdc.MustMarshalJSON(msg))
-}


It is deprecated, see: https://docs.cosmos.network/v0.50/build/migrations/upgrading#modules

Messages no longer need to implement the LegacyMsg interface and implementations of GetSignBytes can be deleted. Because of this change, global legacy Amino codec definitions and their registration in init() can safely be removed as well.

codecov · 2023-09-28T16:18:36Z

Codecov Report

❌ Patch coverage is 64.44444% with 96 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.63%. Comparing base (bc175e5) to head (568b329).
⚠️ Report is 43 commits behind head on master.

Files with missing lines	Patch %	Lines
app/app.go	69.66%	26 Missing and 1 partial ⚠️
app/export.go	6.89%	26 Missing and 1 partial ⚠️
x/posts/simulation/operations.go	0.00%	11 Missing ⚠️
x/profiles/simulation/operations.go	0.00%	9 Missing ⚠️
x/profiles/simulation/utils.go	0.00%	6 Missing ⚠️
x/profiles/module.go	0.00%	5 Missing ⚠️
tests/wasm/helpers.go	90.62%	2 Missing and 1 partial ⚠️
app/desmos/cmd/sign/sign.go	33.33%	2 Missing ⚠️
x/posts/keeper/alias_functions.go	81.81%	2 Missing ⚠️
app/utils.go	0.00%	1 Missing ⚠️
... and 3 more

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #1246       +/-   ##
===========================================
- Coverage   81.04%   17.63%   -63.41%     
===========================================
  Files         218      372      +154     
  Lines       17880   105987    +88107     
===========================================
+ Hits        14490    18695     +4205     
- Misses       2778    85974    +83196     
- Partials      612     1318      +706

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This reverts commit f167dc1.

github-actions Bot added x/profiles Module that allows to create and manage decentralized social profiles x/subspaces Issue on the x/subspaces module x/CLI kind/build Related to the build of the project x/relationships labels Sep 22, 2023

dadamu force-pushed the paul/DCD-415/bump-cosmos-sdk-to-0.50.0 branch 4 times, most recently from cc1acbf to 90d6c17 Compare September 27, 2023 11:25

dadamu changed the title ~~build(deps): bump cosmos sdk to 0.50.0~~ build(deps)!: bump cosmos sdk to 0.50.0 Sep 27, 2023

dadamu force-pushed the paul/DCD-415/bump-cosmos-sdk-to-0.50.0 branch 4 times, most recently from 1a6a59a to 68287ee Compare September 28, 2023 10:51

github-actions Bot added the kind/ci Improve the CI/CD label Sep 28, 2023

dadamu commented Sep 28, 2023

View reviewed changes

dadamu force-pushed the paul/DCD-415/bump-cosmos-sdk-to-0.50.0 branch from 884d2f7 to 0b4cb2e Compare September 28, 2023 14:31

dadamu mentioned this pull request Sep 28, 2023

chore: remove deprecated amino codec and GetSignBytes methods #1251

Closed

19 tasks

dadamu commented Sep 28, 2023

View reviewed changes

dadamu force-pushed the paul/DCD-415/bump-cosmos-sdk-to-0.50.0 branch from 89ecc6e to 6bdb126 Compare September 28, 2023 15:15

dadamu commented Sep 28, 2023

View reviewed changes

dadamu changed the title ~~build(deps)!: bump cosmos sdk to 0.50.0~~ build(deps)!: bump cosmos sdk to v0.50.0 Sep 28, 2023

dadamu marked this pull request as ready for review September 28, 2023 15:52

dadamu requested a review from a team as a code owner September 28, 2023 15:52

dadamu marked this pull request as draft September 28, 2023 17:08

dadamu added 28 commits January 17, 2024 17:19

chore: remove legacy basics module from builder config

7d3eb27

chore: remove deprecated amino codec and signbytes method

49fcaca

fix: remove rest of GetSignBytes methods

b4042cd

chore: run go fmt

f2dc934

chore: move x/upgrade to preblocker

1a70075

docs: add missing supply confing docs

a542da1

chore: remove unused method

f3301d8

fix: make sure sdk set config before initializing app config

5fbc12a

Revert "chore: ignore .dot files"

7eb953d

This reverts commit f167dc1.

fix: update root to support rc.1

e532cc7

test: fix profile set account, logger and invariant tests of x/profiles

f237d8a

build(deps): bumps wasmd to 0.50.0-rc.0 and ibc-go to v8.0.0-beta.1

c0c07bd

chore: fix lint and add back ibc legacy proposal handler

67050d1

ci: change testnet generated dir into .desemos

8d0f155

chore: add changeset entry

5d5a2c5

fix: manually set autocli for non app wire modules

e2cd633

chore: fix lint

be9ba4a

fix: add ibctm and solomachin modules into legacy modules

1eb0544

fix: add missing ibctm and solomachine migration order

9082d0e

build(deps): bump ibc-go to v8.0.0 and cosmos-sdk to v0.50.1

fb39eb3

fix: add paramsclient.ProposalHandler to gov app module basic

f6a78c7

chore: update changeset entry

d94e3b4

chore: fix lint

290fcb9

build(deps): bump wasmd to 0.50.0

4ef9da5

chore: update changeset entry

bc282e6

build(deps): bump cosmos sdk to 0.50.2

b73b8cf

build(deps): bump cosmos-sdk to 0.50.3

e7d043f

chore: update changeset entry

568b329

dadamu force-pushed the paul/DCD-415/bump-cosmos-sdk-to-0.50.0 branch from 76aed35 to 568b329 Compare January 17, 2024 09:24

dadamu changed the title ~~build(deps)!: bump cosmos sdk to v0.50.2~~ build(deps)!: bump cosmos sdk to v0.50.3 Jan 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build(deps)!: bump cosmos sdk to v0.50.3#1246

build(deps)!: bump cosmos sdk to v0.50.3#1246
dadamu wants to merge 110 commits into
masterfrom
paul/DCD-415/bump-cosmos-sdk-to-0.50.0

dadamu commented Sep 22, 2023 •

edited

Loading

Uh oh!

dadamu Sep 28, 2023

Uh oh!

dadamu Sep 28, 2023

Uh oh!

dadamu Sep 28, 2023

Uh oh!

dadamu Sep 28, 2023 •

edited

Loading

Uh oh!

dadamu Sep 28, 2023 •

edited

Loading

Uh oh!

dadamu Sep 28, 2023 •

edited

Loading

Uh oh!

dadamu Sep 28, 2023 •

edited

Loading

Uh oh!

codecov Bot commented Sep 28, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

dadamu commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Author Checklist

Reviewers Checklist

Uh oh!

dadamu Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

dadamu Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

dadamu Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

dadamu Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dadamu Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dadamu Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dadamu Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dadamu commented Sep 22, 2023 •

edited

Loading

dadamu Sep 28, 2023 •

edited

Loading

dadamu Sep 28, 2023 •

edited

Loading

dadamu Sep 28, 2023 •

edited

Loading

dadamu Sep 28, 2023 •

edited

Loading

codecov Bot commented Sep 28, 2023 •

edited

Loading