[components] Fix setting attributes into scoped model on component init - #438
Open
cray0000 wants to merge 1 commit into
Open
[components] Fix setting attributes into scoped model on component init#438cray0000 wants to merge 1 commit into
cray0000 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #418
There are couple of cases when attribute's original path can not be resolved (when attribute is ParentWrapper):
currently those kind of attributes end up being ParentWrappers inside component's model
While there is probably a solution to the 1st case, I don't think there is a simple solution to the 2nd one (it can be implemented in theory though - by automatically creating a reactive functions for this kind of argument values or something like that).
So when ParentWrapper attribute fails to resolve it's original path for creating a ref we should at least init component's model with its renderValue.