Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

Workflow with constant#4440

Closed
tacman wants to merge 4 commits intodeprecated-packages:mainfrom
tacman:workflow-with-constant
Closed

Workflow with constant#4440
tacman wants to merge 4 commits intodeprecated-packages:mainfrom
tacman:workflow-with-constant

Conversation

@tacman
Copy link
Copy Markdown
Contributor

@tacman tacman commented Oct 18, 2022

Ooops, I had harded-coded the transition value in the output, it should be the php constant.

@tacman
Copy link
Copy Markdown
Contributor Author

tacman commented Oct 18, 2022

And my PRs are out of sync, sorry!

@TomasVotruba
Copy link
Copy Markdown
Member

Thanks 👍

Could you narrow it down to 2-3 lines? There is still lot of unrelated transformers being used.

The reason is smaller failing code is easier to detect the bug in 👍

@TomasVotruba
Copy link
Copy Markdown
Member

And my PRs are out of sync, sorry!

Better rebase first, then send PR :)

@TomasVotruba
Copy link
Copy Markdown
Member

Closing as duplicate of #4441

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants