CP-13653 linux-pkg: disable windows-connector's post-push auto-trigger, require manual trigger to publish - #416
Open
vimleshmishra wants to merge 1 commit into
Conversation
vimleshmishra
force-pushed
the
dlpx/pr/vimleshmishra/0ca1958f-2337-4dda-b9a7-86594d41bd00
branch
from
August 27, 2026 10:50
7ff43fd to
158cda0
Compare
…r, require manual trigger to publish PR URL: https://www.github.com/delphix/linux-pkg/pull/416
vimleshmishra
force-pushed
the
dlpx/pr/vimleshmishra/0ca1958f-2337-4dda-b9a7-86594d41bd00
branch
from
August 27, 2026 10:53
158cda0 to
761aa96
Compare
vimleshmishra
requested review from
prakashsurya and
sebroy
and removed request for
sebroy
August 27, 2026 10:55
vimleshmishra
marked this pull request as ready for review
August 27, 2026 10:57
Comment on lines
+65
to
+71
| ## Known caveat | ||
|
|
||
| `GIT_HASH`/`BUILD_INFO` published alongside the artifact reflect the commit at | ||
| the time of the last *real* build, not necessarily current `develop` HEAD — | ||
| this is true regardless of whether a build was triggered automatically or | ||
| manually, and is a pre-existing limitation, not something this change | ||
| introduces. |
Contributor
There was a problem hiding this comment.
I'm not sure I agree with the framing that this is a "caveat".. I view this as a feature, and working as intended..
I'm OK leaving it, just makes it seem like this is a defect, when it's actually the whole point of capturing that information at build time.. so we can map the package contents, to the source code that was used to generate it..
which, by design, will lag the app-gate develop branch for this package..
prakashsurya
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
windows-connector'spost-pushJenkins job auto-triggers on every push todlpx-app-gate, even though connector source changes are infrequent anddlpx-app-gatesees heavy, unrelated traffic. Most of these builds are pure rebuild churn with no actual connector source change, and any real build-health regression is indistinguishable from that noise without added machinery to tell the two apart.Solution
Disable the auto-trigger and require a human to manually trigger a build/publish instead:
DEFAULT_PACKAGE_GIT_URL="none"inpackages/windows-connector/config.sh. The shared Job DSL (devops-gate/jenkins/jobs/linux_pkg_build_package.groovy) already disables a job's push trigger when its git URL is falsy/"none"— no devops-gate change is needed for this.PACKAGE_GIT_URLwould otherwise also resolve to"none"(breaking source fetch), override thefetch()hook in the sameconfig.shto hardcode the realdlpx-app-gateURL directly, bypassing that variable.packages/windows-connector/README.mddocumenting the new process end-to-end: why the trigger was removed, how the mechanism works, how to bumpconnectorDebVersion, how to test viagit-ab-pre-push -b windows-connectorbefore merging, and how to publish a newlatestafter merging.This supersedes the earlier automated skip-detection design (
connectorDebVersioncache-check +NOT_BUILTsignaling), tracked in #407 and devops-gate#4772 — both are being closed/discarded in favor of this simpler approach.Testing Done
Verified end-to-end on a personal Jenkins developer controller (
jenkins-vmishra.dcol2.delphix.com, viaJenkinsManager configure -j ops -g linux-pkgpointed at this branch on my fork):windows-connector/post-pushjob has no SCM/push-trigger property, and its auto-generated description reads "Triggers are disabled for this job, so it must be run manually."post-pushbuild Initial review #1 — it cloned the realdlpx-app-gatesource via thefetch()override,BUILD SUCCESSFUL(Gradle), and the job finishedSUCCESSend-to-end.s3://snapshot-de-images/builds/jenkins-ops.vmishra/.../post-push/latest— the personal-controller-specificjenkins-ops.<user>S3 prefix, not real productionlatest.Notes to Reviewers
Tracked under CP-13653, epic CP-13579.
A companion pointer comment was added in
dlpx-app-gate'sappliance/host/windows/build.gradle, next toconnectorDebVersion, linking back to this package's README — since that's the actual entry point most people will hit when making a connector change.