Skip to content

Performance: 29× speedup across matchers + Coma accuracy improvements #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kPsarakis wants to merge 9 commits into
base: master
Choose a base branch
from

add the NYU benchmark and regression tests in the CI

ef2ea4a
Select commit
Loading
Failed to load commit list.
Open

Performance: 29× speedup across matchers + Coma accuracy improvements #96

add the NYU benchmark and regression tests in the CI
ef2ea4a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 14, 2026 in 1s

95.67% (+0.22%) compared to a0d488d

View this Pull Request on Codecov

95.67% (+0.22%) compared to a0d488d

Details

Codecov Report

❌ Patch coverage is 93.33333% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.67%. Comparing base (a0d488d) to head (ef2ea4a).

Files with missing lines Patch % Lines
valentine/algorithms/cupid/linguistic_matching.py 91.78% 6 Missing ⚠️
valentine/data_sources/polars/polars_table.py 90.76% 4 Missing and 2 partials ⚠️
valentine/__init__.py 71.42% 3 Missing and 1 partial ⚠️
valentine/algorithms/cupid/__init__.py 86.20% 2 Missing and 2 partials ⚠️
.../algorithms/distribution_based/clustering_utils.py 81.25% 2 Missing and 1 partial ⚠️
...lgorithms/distribution_based/quantile_histogram.py 90.00% 1 Missing and 2 partials ⚠️
valentine/algorithms/coma/similarity/tokens.py 97.33% 1 Missing and 1 partial ⚠️
valentine/data_sources/__init__.py 75.00% 2 Missing ⚠️
valentine/data_sources/base_table.py 83.33% 1 Missing and 1 partial ⚠️
valentine/algorithms/coma/similarity/tfidf.py 98.14% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   95.44%   95.67%   +0.22%     
==========================================
  Files          50       53       +3     
  Lines        2351     2633     +282     
  Branches      366      398      +32     
==========================================
+ Hits         2244     2519     +275     
- Misses         64       72       +8     
+ Partials       43       42       -1
Files with missing lines Coverage Δ
valentine/algorithms/coma/coma.py 100.00% <100.00%> (ø)
valentine/algorithms/coma/matchers.py 95.60% <100.00%> (+0.09%) ⬆️
valentine/algorithms/coma/schema.py 100.00% <100.00%> (ø)
valentine/algorithms/coma/similarity/trigram.py 94.11% <100.00%> (+1.26%) ⬆️
...alentine/algorithms/cupid/structural_similarity.py 96.29% <100.00%> (+8.79%) ⬆️
...tine/algorithms/distribution_based/column_model.py 100.00% <100.00%> (+7.69%) ⬆️
...lgorithms/distribution_based/distribution_based.py 99.02% <100.00%> (+0.03%) ⬆️
...lentine/algorithms/distribution_based/emd_utils.py 92.30% <100.00%> (+5.35%) ⬆️
...ne/algorithms/jaccard_distance/jaccard_distance.py 100.00% <100.00%> (+3.84%) ⬆️
...lentine/algorithms/similarity_flooding/__init__.py 100.00% <100.00%> (ø)
... and 16 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov