Skip to content

Raise on unsupported head_dim in SM100 dense FMHA dispatch instead of silently returning uninitialized output #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toffee-desuwa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Raise on unsupported head_dim in SM100 dense FMHA dispatch instead of silently returning uninitialized output #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csrc/sm100/prefill/dense/fmha_cutlass_bwd_sm100.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ void FMHACutlassSM100BwdRun(at::Tensor workspace_buffer, at::Tensor d_o, at::Ten
dq, dk, dv,
softmax_scale, max_seqlen_q, max_seqlen_kv); }
else {
std::cout << "No kernel instantiated for head_dim_qk=" << head_dim_qk << " head_dim_vo=" << head_dim_vo << std::endl;
TORCH_CHECK(false, "No kernel instantiated for head_dim_qk=", head_dim_qk, " head_dim_vo=", head_dim_vo);
}
});

Expand Down
4 changes: 2 additions & 2 deletions csrc/sm100/prefill/dense/fmha_cutlass_fwd_sm100.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ void FMHACutlassSM100FwdRun(at::Tensor workspace_buffer, at::Tensor q, at::Tenso
cumulative_seqlen_q, cumulative_seqlen_kv, o, lse, sm_scale,
max_seqlen_q, max_seqlen_kv);
} else {
std::cout << "No kernel instantiated for head_dim_qk=" << head_dim_qk
<< " head_dim_vo=" << head_dim_vo << std::endl;
TORCH_CHECK(false, "No kernel instantiated for head_dim_qk=", head_dim_qk,
" head_dim_vo=", head_dim_vo);
}
});

Expand Down