Repository navigation
Conversation
Reverts "standalone-indexer: hash image blocks from tokens only" (#43). Token-only image hashing merges blocks of different images at the same position into one tree edge. The compressed radix tree keeps one engine block hash per edge position (edge_index), so the second chain's hashes are only added to the worker lookup, resolve_lookup rejects them, and every later store of that conversation fails with ParentBlockNotFound: a steady 100-160/min on deepseek-ai/DeepSeek-V4.1-Flash reality and routing, all traced to image-bearing stores in a live capture. It also lets a query match a different image's path. deepapi's KV probe now computes vLLM's image id and mixes it into image blocks the same way (deepinfra/backend#5428), so the indexer can key image blocks by content again. The two must roll out together. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
documentation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #43.
Why
Token-only image hashing merges blocks of different images at the same position into one tree edge. The compressed radix tree keeps one engine block hash per edge position (
edge_index), so the second chain's hashes only reach the worker lookup,resolve_lookuprejects them, and every later store of that conversation fails:Failed to find parent blockper minute since kvtest-c707ba7adb (previous image: ~0).Companion
deepapi now computes vLLM's image id in its KV probe and mixes it into image blocks exactly like
compute_block_hash_for_seq(deepinfra/backend#5428; verified against a live engine: identical image ids and all 19 block hashes of a two-image chat). Roll out together: either half alone mismatches image blocks.Also
docs.md: image blocks carry their image id; do not go token-only; known gap that/kv_recoverTreeDumps are token-only for image blocks.Validation
cargo test -p dynamo-kv-router --features kube-discovery --lib: 607 passed.h24 line: companion PR.
🤖 Generated with Claude Code