Remove usage of DataModel from core.py and labeler.py#1101
Merged
fgregg merged 5 commits intodedupeio:mainfrom Sep 23, 2022
Merged
Remove usage of DataModel from core.py and labeler.py#1101fgregg merged 5 commits intodedupeio:mainfrom
fgregg merged 5 commits intodedupeio:mainfrom
Conversation
It's not needed in there, so should just pass what is needed. This is prep for further refactoring of removing datamodel more
We don't use it after the initial construction, so don't store it
We only need the abstract requirement of a Featurizer function.
NickCrews
force-pushed
the
extract-datamodel
branch
from
7350aed to
b70e283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #1098, but now split up.