Skip to content

fix(chat): guard tiptap editor.view access in slash mention #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viniciusventura29 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(chat): guard tiptap editor.view access in slash mention #3324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions apps/mesh/src/web/components/chat/tiptap/mention/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,17 @@ function useMenuNavigation<T>({
// Attach keyboard listener to editor
// eslint-disable-next-line ban-use-effect/ban-use-effect
useEffect(() => {
const dom = editor.view.dom;
if (editor?.isDestroyed) return undefined;

// Guard against editor being destroyed
if (editor?.isDestroyed || !dom) {
let dom: HTMLElement;
try {
dom = editor.view.dom;
} catch {
// Editor view not mounted yet (or already torn down). Bail; the effect
// will re-run when the editor reference changes.
return undefined;
}
if (!dom) return undefined;

const handleKeyDown = (event: KeyboardEvent) => {
const currentItems = itemsRef.current;
Expand Down
Loading