Add GPU selection to cloud connect UI#957
Open
hthillman wants to merge 2 commits intoja/multi-gpufrom
Open
Conversation
Replaces the on/off Remote Inference toggle in Settings → Daydream Account with a split button + dropdown that lets users pick which Livepeer GPU their cloud session targets. Options are H100 (2.5 credits/min), RTX 4090 and RTX 5090 (1.25 credits/min each). The last-used GPU is persisted in localStorage so the button is pre-populated on return, and while connecting a cancel (X) button replaces the caret. When connected, the dropdown surfaces "Switch GPU" and "Disconnect"; Switch GPU auto-reopens the picker on disconnect. Onboarding is unchanged — CloudAuthStep and CloudConnectingStep still call connectToCloud() with no arg, so first-time users always land on H100 regardless of prior selection. Backend threads the new gpu field (Literal["h100","rtx4090","rtx5090"]) through CloudConnectRequest → cloud_manager.connect_background → LivepeerConnection → LivepeerClient → _resolve_livepeer_app_id. Explicit app_id still wins over gpu, which wins over the SCOPE_CLOUD_GPU env var, which falls back to H100 — preserving CI, local cloud dev, and the existing env-var workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Hunter Hillman <hthillman@gmail.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 fal.ai Preview Deployment
Livepeer Runner
Testing Livepeer Mode |
Collaborator
|
Ran a quick test, seems to be functional. Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the on/off Remote Inference toggle in Settings → Daydream Account with a split button + dropdown that lets users pick which Livepeer GPU their cloud session targets. Options are H100 (2.5 credits/min), RTX 4090 and RTX 5090 (1.25 credits/min each). The last-used GPU is persisted in localStorage so the button is pre-populated on return, and while connecting a cancel (X) button replaces the caret. When connected, the dropdown surfaces "Switch GPU" and "Disconnect"; Switch GPU auto-reopens the picker on disconnect.
Onboarding is unchanged — CloudAuthStep and CloudConnectingStep still call connectToCloud() with no arg, so first-time users always land on H100 regardless of prior selection.
Backend threads the new gpu field (Literal["h100","rtx4090","rtx5090"]) through CloudConnectRequest → cloud_manager.connect_background → LivepeerConnection → LivepeerClient → _resolve_livepeer_app_id. Explicit app_id still wins over gpu, which wins over the SCOPE_CLOUD_GPU env var, which falls back to H100 — preserving CI, local cloud dev, and the existing env-var workflow.