Skip to content

fix(longlive): add logger + warning when KV cache write is skipped (#921) #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
livepeer-tessa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(longlive): add logger + warning when KV cache write is skipped (#921) #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/scope/core/pipelines/longlive/modules/causal_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Modified from https://github.com/NVlabs/LongLive
# SPDX-License-Identifier: CC-BY-NC-SA-4.0
import logging
import math

import torch
Expand All @@ -13,6 +14,7 @@
)

from scope.core.pipelines.wan2_1.modules.attention import attention

from .model import (
WAN_CROSSATTENTION_CLASSES,
MLPProj,
Expand All @@ -30,6 +32,8 @@
flex_attention, dynamic=False, mode="max-autotune-no-cudagraphs"
)

logger = logging.getLogger(__name__)


def causal_rope_apply(x, grid_sizes, freqs, start_frame=0):
n, c = x.size(2), x.size(3) // 2
Expand Down Expand Up @@ -331,6 +335,15 @@ def qkv_fn(x):
temp_v[:, write_start_index:local_end_index] = v[
:, roped_offset : roped_offset + write_len
]
else:
logger.warning(
"KV cache write skipped (roll_and_insert): "
"write_start_index (%d) >= local_end_index (%d) — "
"cache indices may be stale after a rapid mode transition. "
"(See daydreamlive/scope#921)",
write_start_index,
local_end_index,
)

# Save cache update info for later use
cache_update_info = {
Expand Down Expand Up @@ -377,6 +390,15 @@ def qkv_fn(x):
temp_v[:, write_start_index:local_end_index] = v[
:, roped_offset : roped_offset + write_len
]
else:
logger.warning(
"KV cache write skipped (direct_insert): "
"write_start_index (%d) >= local_end_index (%d) — "
"cache indices may be stale after a rapid mode transition. "
"(See daydreamlive/scope#921)",
write_start_index,
local_end_index,
)

# Save cache update info for later use
cache_update_info = {
Expand Down
Loading