Skip to content

Allow bench workflow to run on PRs from forks #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ashkrisk wants to merge 5 commits into
base: main
Choose a base branch
from
+3 −2
Draft

Allow bench workflow to run on PRs from forks #656

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb8ff82
Allow bench workflow to run on PRs from forks
ashkrisk Apr 7, 2026
f035366
Trigger bench workflow on workflow file changes
ashkrisk Apr 7, 2026
486f26d
Use nested object instead of include
ashkrisk Apr 7, 2026
6ab5846
Simplify by using SHA only
ashkrisk Apr 7, 2026
22b2122
Add back run-bench to trigger list
ashkrisk Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/run-bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ on:
- '**/src/main/java/**'
- 'pom.xml'
- '**/pom.xml'
- '.github/workflows/run-bench.yml'

jobs:
# Job to generate the matrix configuration
Expand All @@ -41,8 +42,8 @@ jobs:

# Default branches based on event type
if [[ "${{ github.event_name }}" == "pull_request" ]]; then
echo "Pull request detected. Using main and PR branch: ${{ github.head_ref }}"
BRANCHES='["main", "${{ github.head_ref }}"]'
Copy link
Copy Markdown
Contributor

@jshook jshook Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a change from "branch" to "sha", rather than also adding support for the sha. Don't we need it to work for both?

echo "Pull request detected. Using main and PR commit SHA: ${{ github.event.pull_request.head.sha }}"
BRANCHES='["main", "${{ github.event.pull_request.head.sha }}"]'
elif [[ "${{ github.event_name }}" == "workflow_dispatch" && -n "${{ github.event.inputs.branches }}" ]]; then
# Parse space-separated branches input into JSON array
echo "Workflow dispatch with branches input detected"
Expand Down
Loading