Skip to content

CNDB-13742 ReadCallback logs when replica doesn't respond#2281

Open
zgorzalyj wants to merge 2 commits intomainfrom
CNDB-13742
Open

CNDB-13742 ReadCallback logs when replica doesn't respond#2281
zgorzalyj wants to merge 2 commits intomainfrom
CNDB-13742

Conversation

@zgorzalyj
Copy link
Copy Markdown

Summary

https://github.com/riptano/cndb/issues/13742
Lack of information when replica doesn't respond.
Changes

Add new log which contains information about timeout

@github-actions
Copy link
Copy Markdown

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@zgorzalyj zgorzalyj marked this pull request as ready for review March 19, 2026 16:08
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@driftx driftx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question but it looks good.

@@ -138,7 +141,29 @@ public void awaitResults() throws ReadFailureException, ReadTimeoutException
if (Tracing.isTracing())
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being inside this block will require that tracing is enabled, which is different from trace level logging (which would also need to be enabled.) Is that intended?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is intentional. The production code logs these details inside Tracing.isTracing() conditional blocks, so the logs only appear when tracing is actively enabled for a session, not just when TRACE log level is configured. This keeps log volume minimal in production while still allowing targeted debugging through tracing when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants