Skip to content

CNDB-16395: Add SAI tests mixing static and non-static columns#2276

Open
pkolaczk wants to merge 1 commit intomainfrom
c16395-static-tests
Open

CNDB-16395: Add SAI tests mixing static and non-static columns#2276
pkolaczk wants to merge 1 commit intomainfrom
c16395-static-tests

Conversation

@pkolaczk
Copy link
Copy Markdown

@pkolaczk pkolaczk commented Mar 16, 2026

There is non-trivial amount of logic in SAI iterators code that
deal with PrimaryKey objects pointing to full partitions
and primary keys pointing to single rows. The tests added here
are a small step towards testing those code paths better.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@pkolaczk pkolaczk requested a review from k-rus March 16, 2026 16:33
There is non-trivial amount of logic in SAI iterators code that
deal with PrimaryKey objects pointing to full partitions
and primary keys pointing to single rows. The tests added here
are a small step towards testing those code paths better.
@pkolaczk pkolaczk force-pushed the c16395-static-tests branch from 98f5121 to b1f9394 Compare March 16, 2026 16:36
@pkolaczk
Copy link
Copy Markdown
Author

No need for a CNDB PR, this issue is pure testing.

@sonarqubecloud
Copy link
Copy Markdown

@cassci-bot
Copy link
Copy Markdown

❌ Build ds-cassandra-pr-gate/PR-2276 rejected by Butler


2 regressions found
See build details here


Found 2 new test failures

Test Explanation Runs Upstream
o.a.c.index.sai.cql.VectorCompaction100dTest.testZeroOrOneToManyCompaction[fa false] REGRESSION 🔴 0 / 27
o.a.c.index.sai.cql.VectorSiftSmallTest.testMultiSegmentBuild[ec true false] NEW 🔴 0 / 27

Found 5 known test failures

@pkolaczk pkolaczk requested review from a team and removed request for k-rus March 16, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants