Skip to content

Install-DbaWhoIsActive - Select version-appropriate SQL file based on server version #10341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreasjordan wants to merge 3 commits into
base: development
Choose a base branch
from
+37 −21
Open

Install-DbaWhoIsActive - Select version-appropriate SQL file based on server version #10341

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9babf4
Install-DbaWhoIsActive - Select version-appropriate SQL file based on…
github-actions[bot] Apr 10, 2026
70ba714
Install-DbaWhoIsActive - Fix version folder matching for single-year …
github-actions[bot] Apr 12, 2026
6255edb
Install-DbaWhoIsActive - Simplify version-based SQL file selection
github-actions[bot] Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 37 additions & 21 deletions public/Install-DbaWhoIsActive.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,27 +133,6 @@ function Install-DbaWhoIsActive {
}
}

if ($PSCmdlet.ShouldProcess($env:computername, "Reading SQL file into memory")) {
$sqlfile = (Get-ChildItem -Path $localCachedCopy -Filter 'sp_WhoIsActive.sql').FullName
if ($null -eq $sqlfile) {
Write-Message -Level Verbose -Message "New filename sp_WhoIsActive.sql not found, using old filename who_is_active.sql."
$sqlfile = (Get-ChildItem -Path $localCachedCopy -Filter 'who_is_active.sql').FullName
}
Write-Message -Level Verbose -Message "Using $sqlfile."

$sql = [IO.File]::ReadAllText($sqlfile)
$sql = $sql -replace 'USE master', ''

$matchString = 'Who Is Active? v'

If ($sql -like "*$matchString*") {
$posStart = $sql.IndexOf("$matchString")
$PosEnd = $sql.IndexOf(")", $PosStart)
$versionWhoIsActive = $sql.Substring($posStart + $matchString.Length, $posEnd - ($posStart + $matchString.Length) + 1).TrimEnd()
} Else {
$versionWhoIsActive = ''
}
}
}

process {
Expand All @@ -166,6 +145,43 @@ function Install-DbaWhoIsActive {
Stop-Function -Message "Failure" -Category ConnectionError -ErrorRecord $_ -Target $instance -Continue
}

# Select the appropriate SQL file based on the target server's version.
# sp_WhoIsActive ships version-specific SQL files in subfolders:
# - Folder "2008" for SQL Server 2005-2008 (VersionMajor <= 10)
# - Folder "2019" for SQL Server 2012-2019 (VersionMajor <= 15)
# - Base folder for SQL Server 2022+ (VersionMajor >= 16)
if ($server.VersionMajor -le 10) {
$sqlfile = Join-Path -Path (Join-Path -Path $localCachedCopy -ChildPath '2008') -ChildPath 'sp_WhoIsActive.sql'
} elseif ($server.VersionMajor -le 15) {
$sqlfile = Join-Path -Path (Join-Path -Path $localCachedCopy -ChildPath '2019') -ChildPath 'sp_WhoIsActive.sql'
} else {
$sqlfile = Join-Path -Path $localCachedCopy -ChildPath 'sp_WhoIsActive.sql'
}

if (-not (Test-Path -Path $sqlfile)) {
Write-Message -Level Verbose -Message "Version-appropriate file not found at $sqlfile, falling back to old filename who_is_active.sql."
$whoIsActiveOldFile = Get-ChildItem -Path $localCachedCopy -Filter 'who_is_active.sql' -Recurse | Select-Object -First 1
if ($whoIsActiveOldFile) {
$sqlfile = $whoIsActiveOldFile.FullName
} else {
Stop-Function -Message "No SQL file found in $localCachedCopy." -Target $instance -Continue
continue
}
}

Write-Message -Level Verbose -Message "Using $sqlfile."
$sql = [IO.File]::ReadAllText($sqlfile)
$sql = $sql -replace 'USE master', ''

$matchString = 'Who Is Active? v'
if ($sql -like "*$matchString*") {
$posStart = $sql.IndexOf($matchString)
$posEnd = $sql.IndexOf(")", $posStart)
$versionWhoIsActive = $sql.Substring($posStart + $matchString.Length, $posEnd - ($posStart + $matchString.Length) + 1).TrimEnd()
} else {
$versionWhoIsActive = ''
}

if (-not $Database) {
if ($PSCmdlet.ShouldProcess($instance, "Prompting with GUI list of databases")) {
$Database = Show-DbaDbList -SqlInstance $server -Title "Install sp_WhoisActive" -Header "To deploy sp_WhoisActive, select a database or hit cancel to quit." -DefaultDb "master"
Expand Down
Loading