Skip to content

Copy-DbaLinkedServer - Fix provider compatibility for SQL 2022/2025 #10337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
andreasjordan wants to merge 1 commit into
base: development
Choose a base branch
from
+30 −7
Draft

Copy-DbaLinkedServer - Fix provider compatibility for SQL 2022/2025 #10337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 30 additions & 7 deletions public/Copy-DbaLinkedServer.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,13 @@ function Copy-DbaLinkedServer {
$serverList = $serverlist | Where-Object Name -NotIn $ExcludeLinkedServer
}

# Provider compatibility mappings for SQL Server version migrations
# SQL Server 2022+ uses MSOLEDBSQL19 (OLE DB Driver 19) while older versions use MSOLEDBSQL (OLE DB Driver 18)
$providerCompatMap = @{
"MSOLEDBSQL" = "MSOLEDBSQL19"
"MSOLEDBSQL19" = "MSOLEDBSQL"
}

foreach ($currentLinkedServer in $serverlist) {
$provider = $currentLinkedServer.ProviderName
try {
Expand Down Expand Up @@ -192,14 +199,19 @@ function Copy-DbaLinkedServer {

# This does a check to warn of missing OleDbProviderSettings but should only be checked on SQL on Windows
if ($destServer.Settings.OleDbProviderSettings.Name.Length -ne 0) {
if (!$destServer.Settings.OleDbProviderSettings.Name -contains $provider -and !$provider.StartsWith("SQLN")) {
if ($Pscmdlet.ShouldProcess($destinstance, "$($destServer.Name) does not support the $provider provider. Skipping $linkedServerName.")) {
$copyLinkedServer.Status = "Skipped"
$copyLinkedServer.Notes = "Missing provider"
$copyLinkedServer | Select-DefaultView -Property DateTime, SourceServer, DestinationServer, Name, Type, Status, Notes -TypeName MigrationObject
Write-Message -Level Verbose -Message "$($destServer.Name) does not support the $provider provider. Skipping $linkedServerName."
if (-not ($destServer.Settings.OleDbProviderSettings.Name -contains $provider) -and -not $provider.StartsWith("SQLN")) {
# Check if a compatible alternative provider is available before skipping
$hasCompatible = $providerCompatMap.ContainsKey($provider) -and
($destServer.Settings.OleDbProviderSettings.Name -contains $providerCompatMap[$provider])
if (-not $hasCompatible) {
if ($Pscmdlet.ShouldProcess($destinstance, "$($destServer.Name) does not support the $provider provider. Skipping $linkedServerName.")) {
$copyLinkedServer.Status = "Skipped"
$copyLinkedServer.Notes = "Missing provider"
$copyLinkedServer | Select-DefaultView -Property DateTime, SourceServer, DestinationServer, Name, Type, Status, Notes -TypeName MigrationObject
Write-Message -Level Verbose -Message "$($destServer.Name) does not support the $provider provider. Skipping $linkedServerName."
}
continue
}
continue
}
}

Expand Down Expand Up @@ -238,6 +250,17 @@ function Copy-DbaLinkedServer {
$sql = $currentLinkedServer.Script() | Out-String
Write-Message -Level Debug -Message $sql

# Automatically map providers for compatibility between SQL Server versions
# e.g., SQL Server 2022+ uses MSOLEDBSQL19 while SQL Server 2019 and older use MSOLEDBSQL
$destProviderNames = @($destServer.Settings.OleDbProviderSettings.Name)
if ($destProviderNames.Count -gt 0 -and -not ($destProviderNames -contains $provider) -and $providerCompatMap.ContainsKey($provider)) {
$mappedProvider = $providerCompatMap[$provider]
if ($destProviderNames -contains $mappedProvider) {
Write-Message -Level Verbose -Message "Provider '$provider' not available on $($destServer.Name). Using compatible provider '$mappedProvider'."
$sql = $sql -replace "N'$([regex]::Escape($provider))'", "N'$mappedProvider'"
}
}

if ($UpgradeSqlClient -and $sql -match "sqlncli") {
$destProviders = $destServer.Settings.OleDbProviderSettings | Where-Object { $_.Name -like 'SQLNCLI*' }
$newProvider = $destProviders | Sort-Object Name -Descending | Select-Object -First 1 -ExpandProperty Name
Expand Down
Loading