Skip to content

Fix timing issues in tests for Get-DbaExternalProcess and Stop-DbaExternalProcess #10330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreasjordan wants to merge 1 commit into
base: development
Choose a base branch
from
+22 −4
Open

Fix timing issues in tests for Get-DbaExternalProcess and Stop-DbaExternalProcess #10330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions tests/Get-DbaExternalProcess.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,17 @@ Describe $CommandName -Tag IntegrationTests {
GO"

# remove sql file
Remove-Item -Path $sqlFile
foreach ($run in 1..20) {
try {
Remove-Item -Path $sqlFile -ErrorAction Stop
break
} catch {
Start-Sleep -Seconds 1
}
}
if (Test-Path -Path $sqlFile) {
Write-Warning -Message "File $sqlFile could not be removed."
}

$PSDefaultParameterValues.Remove("*-Dba*:EnableException")
}
Expand All @@ -78,7 +88,6 @@ Describe $CommandName -Tag IntegrationTests {
It "returns a process" {
Start-Sleep -Seconds 1
$results = Get-DbaExternalProcess -ComputerName $computerName | Where-Object Name -eq "cmd.exe"
Start-Sleep -Seconds 5
$results.ComputerName | Should -Be $computerName
$results.Name | Should -Be "cmd.exe"
$results.ProcessId | Should -Not -Be $null
Expand Down
13 changes: 11 additions & 2 deletions tests/Stop-DbaExternalProcess.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,17 @@ Describe $CommandName -Tag IntegrationTests {
GO"

# remove sql file
Remove-Item -Path $sqlFile
foreach ($run in 1..20) {
try {
Remove-Item -Path $sqlFile -ErrorAction Stop
break
} catch {
Start-Sleep -Seconds 1
}
}
if (Test-Path -Path $sqlFile) {
Write-Warning -Message "File $sqlFile could not be removed."
}

$PSDefaultParameterValues.Remove("*-Dba*:EnableException")
}
Expand All @@ -79,7 +89,6 @@ Describe $CommandName -Tag IntegrationTests {
It "returns results" {
Start-Sleep -Seconds 1
$results = Get-DbaExternalProcess -ComputerName $computerName | Select-Object -First 1 | Stop-DbaExternalProcess
Start-Sleep -Seconds 5
$results.ComputerName | Should -Be $computerName
$results.Name | Should -Be "cmd.exe"
$results.ProcessId | Should -Not -BeNullOrEmpty
Expand Down
Loading