Skip to content

Bug fixes#524

Merged
vish-cs merged 1 commit into
datacommonsorg:masterfrom
vish-cs:bug
Jun 5, 2026
Merged

Bug fixes#524
vish-cs merged 1 commit into
datacommonsorg:masterfrom
vish-cs:bug

Conversation

@vish-cs

@vish-cs vish-cs commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Solves two issues:
a) Nesting of substitution variables (_VERSION string within dataflow template path) in the cloud build config
b) Handling of empty import list and job IDs to not cause ingestion workflow to fail

@vish-cs vish-cs requested a review from gmechali June 5, 2026 17:09
@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 minor

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
CodeStyle 1 minor

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the construction of the Dataflow template path within the Cloud Build and deployment configurations, moving the versioned filename resolution to the deployment step. It also updates the ingestion helper service in Python to gracefully handle empty import lists and job IDs by logging the events and returning successful HTTP 200 responses instead of raising errors. As there are no review comments, I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@vish-cs vish-cs merged commit f57e472 into datacommonsorg:master Jun 5, 2026
9 of 10 checks passed
gmechali pushed a commit to gmechali/import that referenced this pull request Jun 5, 2026
Solves two issues:
a) Nesting of substitution variables (_VERSION string within dataflow
template path) in the cloud build config
b) Handling of empty import list and job IDs to not cause ingestion
workflow to fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants