Bump Terraform provider to v1.113.0 #4991
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| RecordRequests = false | ||
|
|
||
| [Env] | ||
| DATABRICKS_CACHE_ENABLED = 'false' | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -308,7 +308,7 @@ | |
| { | ||
| "headers": { | ||
| "User-Agent": [ | ||
| "databricks-tf-provider/1.113.0 databricks-sdk-go/[SDK_VERSION] go/1.24.0 os/[OS] cli/[DEV_VERSION] terraform/1.5.5 sdk/sdkv2 resource/schema auth/pat" | ||
| ] | ||
| }, | ||
| "method": "GET", | ||
|
|
@@ -317,7 +317,7 @@ | |
| { | ||
| "headers": { | ||
| "User-Agent": [ | ||
| "databricks-tf-provider/1.113.0 databricks-sdk-go/[SDK_VERSION] go/1.24.0 os/[OS] cli/[DEV_VERSION] terraform/1.5.5 sdk/sdkv2 resource/schema auth/pat" | ||
| ] | ||
| }, | ||
| "method": "POST", | ||
|
|
@@ -327,3 +327,39 @@ | |
| "name": "myschema" | ||
| } | ||
| } | ||
| { | ||
| "headers": { | ||
| "User-Agent": [ | ||
| "databricks-tf-provider/1.113.0 databricks-sdk-go/[SDK_VERSION] go/1.24.0 os/[OS] cli/[DEV_VERSION] terraform/1.5.5" | ||
| ] | ||
| }, | ||
| "method": "GET", | ||
| "path": "/.well-known/databricks-config" | ||
| } | ||
| { | ||
| "headers": { | ||
| "User-Agent": [ | ||
| "databricks-tf-provider/1.113.0 databricks-sdk-go/[SDK_VERSION] go/1.24.0 os/[OS] cli/[DEV_VERSION] terraform/1.5.5" | ||
| ] | ||
| }, | ||
| "method": "GET", | ||
| "path": "/.well-known/databricks-config" | ||
| } | ||
| { | ||
| "headers": { | ||
| "User-Agent": [ | ||
| "databricks-tf-provider/1.113.0 databricks-sdk-go/[SDK_VERSION] go/1.24.0 os/[OS] cli/[DEV_VERSION] terraform/1.5.5" | ||
| ] | ||
| }, | ||
| "method": "GET", | ||
| "path": "/.well-known/databricks-config" | ||
| } | ||
| { | ||
| "headers": { | ||
| "User-Agent": [ | ||
| "databricks-tf-provider/1.113.0 databricks-sdk-go/[SDK_VERSION] go/1.24.0 os/[OS] cli/[DEV_VERSION] terraform/1.5.5" | ||
| ] | ||
| }, | ||
| "method": "GET", | ||
| "path": "/.well-known/databricks-config" | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Does this match the # of command invocations? Just to gut check that we're not doing 1 of these per TF request.
Member
Author
There was a problem hiding this comment. Yes, it's per terraform invocation, not per API request. The provider calls /.well-known/databricks-config during initialization, so it happens roughly twice per terraform operation (plan, apply). Deploy runs plan+apply so you see ~4 provider calls, destroy similarly gets ~6. The single calls with cli/... user-agent are from the CLI SDK's own config resolution. I think there might be an effort looking into adding caching for this, but we'd have to ask @tanmay-db
Contributor
There was a problem hiding this comment. The current TF Release (v1.113.0) doesn't directly rely on this end point. This is called during Host metadata resolution in Go SDK and that is bumped in TF so I am guessing this is why this is needed here (not sure)? In very near future we plan to use this in TF The plan is to add this in HostType() in Go SDK so
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| package schema | ||
|
|
||
| const ProviderVersion = "1.113.0" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not relevant for this case, I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TF provider v1.113.0 makes extra /.well-known/databricks-config calls that the direct engine doesn't. Since both variants share out.requests.txt, the terraform variant now produces more requests than direct, causing a divergence. Disabling recording for this test sidesteps it since the test only cares about the plan output anyway.