Skip to content

[PLUGIN-1948] Handle unsupported BigQuery table types gracefully in PartitionedBigQueryInputFormat #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adrikagupta merged 1 commit into from
Apr 27, 2026
+9 −2
Merged

[PLUGIN-1948] Handle unsupported BigQuery table types gracefully in PartitionedBigQueryInputFormat #1610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/main/java/io/cdap/plugin/gcp/bigquery/source/PartitionedBigQueryInputFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ private void processQuery(JobContext context) throws IOException, InterruptedExc
query = generateQuery(partitionFromDate, partitionToDate, filter, datasetProjectId,
datasetId,
tableName, limit, orderBy,
isPartitionFilterRequired, (StandardTableDefinition) tableDefinition);
isPartitionFilterRequired, tableDefinition);
}

if (query != null) {
Expand All @@ -181,14 +181,21 @@ private void processQuery(JobContext context) throws IOException, InterruptedExc
@VisibleForTesting
String generateQuery(String partitionFromDate, String partitionToDate, String filter,
String datasetProject, String dataset, String table, String limit, String orderBy,
Boolean isPartitionFilterRequired, StandardTableDefinition tableDefinition) {
Boolean isPartitionFilterRequired, TableDefinition tableDef) {

if (Strings.isNullOrEmpty(filter) && Strings.isNullOrEmpty(orderBy) && Strings.isNullOrEmpty(
limit)
&& Strings.isNullOrEmpty(partitionFromDate) && Strings.isNullOrEmpty(partitionToDate)) {
return null;
}

if (!(tableDef instanceof StandardTableDefinition)) {
throw new IllegalArgumentException(
String.format("Unsupported BigQuery table type for filtering/partitioning: %s. " +
"Cannot apply filters, limits, or ordering.", tableDef.getType()));
}

StandardTableDefinition tableDefinition = (StandardTableDefinition) tableDef;
RangePartitioning rangePartitioning = tableDefinition.getRangePartitioning();
TimePartitioning timePartitioning = tableDefinition.getTimePartitioning();
StringBuilder condition = new StringBuilder();
Expand Down
Loading