Skip to content

test: log dynamic EvoNode helper exceptions #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thepastaclaw wants to merge 1 commit into
base: develop
Choose a base branch
from
+12 −4
Draft

test: log dynamic EvoNode helper exceptions #7313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions test/functional/test_framework/test_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1624,8 +1624,12 @@ def dynamically_add_masternode(self, evo=False, rnd=None, should_be_rejected=Fal
try:
created_mn_info = self.dynamically_prepare_masternode(mn_idx, evo, rnd)
protx_success = True
except Exception:
self.log.info("dynamically_prepare_masternode failed")
except Exception as e:
log_fn = self.log.info if should_be_rejected else self.log.exception
log_fn(
"dynamically_prepare_masternode failed (mn_idx=%s, evo=%s, rnd=%s, should_be_rejected=%s): %r",
mn_idx, evo, rnd, should_be_rejected, getattr(e, "error", repr(e)),
)

assert_equal(protx_success, not should_be_rejected)

Expand Down Expand Up @@ -1707,8 +1711,12 @@ def dynamically_evo_update_service(self, evo_info: MasternodeInfo, rnd=None, sho
evo_info.bury_tx(self, genIdx=0, txid=protx_result, depth=1)
self.log.info("Updated EvoNode %s: platformNodeID=%s, platformP2PPort=%s, platformHTTPPort=%s" % (evo_info.proTxHash, platform_node_id, addrs_platform_p2p, addrs_platform_https))
protx_success = True
except Exception:
self.log.info("protx_evo rejected")
except Exception as e:
log_fn = self.log.info if should_be_rejected else self.log.exception
log_fn(
"protx_evo rejected (proTxHash=%s, rnd=%s, should_be_rejected=%s): %r",
evo_info.proTxHash, rnd, should_be_rejected, getattr(e, "error", repr(e)),
)

assert_equal(protx_success, not should_be_rejected)

Expand Down
Loading