Skip to content

Fix inconsistent hover effects on dark-background elements #9383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SanskaarUndale21 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix inconsistent hover effects on dark-background elements #9383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae36e4
Fix inconsistent hover effects on dark-background elements (#8886)
SanskaarUndale21 May 8, 2026
731bd14
Refactor hover fix to use semantic .pub-dark-bg CSS class
SanskaarUndale21 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/lib/frontend/templates/views/shared/layout.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ d.Node pageLayoutNode({
),
if (searchBanner != null)
d.div(
classes: ['_banner-bg'],
classes: ['_banner-bg', 'pub-dark-bg'],
child: d.div(
classes: ['container', if (isLanding) 'home-banner'],
children: [
Expand Down Expand Up @@ -343,7 +343,7 @@ d.Node _siteFooterNode({

return d.element(
'footer',
classes: ['site-footer'],
classes: ['site-footer', 'pub-dark-bg'],
children: [
link('${urls.dartSiteRoot}/', 'Dart language', sep: false),
if (moderationNode != null) moderationNode,
Expand Down
2 changes: 1 addition & 1 deletion app/lib/frontend/templates/views/shared/site_header.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ d.Node siteHeaderNode({
required SearchForm? searchForm,
}) {
return d.div(
classes: ['site-header'],
classes: ['site-header', 'pub-dark-bg'],
children: [
d.button(classes: ['hamburger'], ariaLabel: 'menu toggle'),
if (pageType != PageType.landing)
Expand Down
12 changes: 12 additions & 0 deletions pkg/web_css/lib/src/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,18 @@ a {
@include variables.brightness-on-hover;
}

// Sections with a permanently dark background (header, footer, banner) use
// brightness(120%) on hover in both themes, overriding the light-mode default.
.light-theme .pub-dark-bg a:hover {
filter: brightness(120%);
}

// Links directly wrapping a monochrome icon rely on the icon's opacity-based
// hover feedback; suppress the brightness filter to avoid stacking effects.
a:has(> .pub-monochrome-icon):hover {
filter: none;
}

main {
min-height: calc(100vh - 130px); // top nav (50) + footer (80)
margin-bottom: 32px;
Expand Down
3 changes: 2 additions & 1 deletion pkg/web_css/lib/src/_site_header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@
opacity: 1.0;

&:hover {
opacity: 0.8;
// The header has a dark background; brighten on hover instead of dimming.
filter: brightness(120%);
}
}

Expand Down