Skip to content

fix: NLTK data download during Docker builds #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peeeteeer wants to merge 1 commit into from
Closed

fix: NLTK data download during Docker builds #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ RUN apt-get update \

COPY requirements.txt .
RUN pip install --no-cache-dir -r requirements.txt
ENV NLTK_DATA=/app/nltk_data

# Download standard NLTK data, to prevent unstructured from downloading packages at runtime
RUN python -m nltk.downloader -d /app/nltk_data punkt_tab averaged_perceptron_tagger averaged_perceptron_tagger_eng
ENV NLTK_DATA=/app/nltk_data
RUN python -m nltk.downloader --exit-on-error -d /app/nltk_data punkt_tab averaged_perceptron_tagger averaged_perceptron_tagger_eng

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Make NLTK download failures fail the image build

When any NLTK package cannot be fetched or resolved, --exit-on-error does not make python -m nltk.downloader return a non-zero status; I checked the NLTK CLI source and this option only sets halt_on_error, then the main loop breaks on rv == False without calling sys.exit, so Docker will still continue and can publish an image missing the required data. Please wrap this in a Python one-liner that exits based on nltk.download(...) results or otherwise force a non-zero status; the same command is present in Dockerfile.lite.

Useful? React with 👍 / 👎.


# Disable Unstructured analytics
ENV SCARF_NO_ANALYTICS=true
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.lite
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ RUN apt-get update \

COPY requirements.lite.txt .
RUN pip install --no-cache-dir -r requirements.lite.txt
ENV NLTK_DATA=/app/nltk_data

# Download standard NLTK data, to prevent unstructured from downloading packages at runtime
RUN python -m nltk.downloader -d /app/nltk_data punkt_tab averaged_perceptron_tagger averaged_perceptron_tagger_eng
ENV NLTK_DATA=/app/nltk_data
RUN python -m nltk.downloader --exit-on-error -d /app/nltk_data punkt_tab averaged_perceptron_tagger averaged_perceptron_tagger_eng

# Disable Unstructured analytics
ENV SCARF_NO_ANALYTICS=true
Expand Down
Loading